Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1798073002: Optimize flattening of cons strings with equal left and right-side. (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Optimize flattening of cons strings with equal left and right-side. This significantly speeds up flattening repeat strings (e.g., '.'.repeat(1000)). BUG= Committed: https://crrev.com/4ebd97b42637d14292751f55143c1d98763106d4 Cr-Commit-Position: refs/heads/master@{#34751}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/objects.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-14 15:47:47 UTC) #2
Yang
lgtm. nice!
4 years, 9 months ago (2016-03-14 15:50:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798073002/1
4 years, 9 months ago (2016-03-14 15:56:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-14 16:19:09 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 16:20:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ebd97b42637d14292751f55143c1d98763106d4
Cr-Commit-Position: refs/heads/master@{#34751}

Powered by Google App Engine
This is Rietveld 408576698