Removed CORE_EXPORT from APIs at NodeTraversal.

Removed CORE_EXPORT from APIs at NodeTraversal.

CORE_EXPORT was added at crrev.com/1628283002 and it caused performance
degrade on traversing dom.
This patch adds nextRadioButtonInGroup at RadioInputType and makes
AXRadioInput use it to avoid using dom traversing APIs directly.

BUG=592282
Committed: https://crrev.com/d420eecfc4f7881986bfbc623c3598a0b72c06c9
Cr-Commit-Position: refs/heads/master@{#381371}

[je_julie(Not used), 2016-03-14 16:10:28]

je_julie.kim@samsung.com changed reviewers:
+ dmazzoni@chromium.org, keishi@chromium.org, tkent@chromium.org

[je_julie(Not used), 2016-03-14 16:10:29]

Hi tkent, keishi and Dominic,

This patch fixes performance degrade at crbug.com/592282 caused by
crrev.com/592282. Thanks to tkent, I found that CORE_EXPORT caused DOM traversal
performance. In order to avoid direct using DOM traversal API at AX module, I
used nextElement at RadioInputType. I could see it's intended to be used locally
but I made it exported API to use it at AX module. PTAL.

[tkent, 2016-03-14 23:30:14]

https://codereview.chromium.org/1798043002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/forms/RadioInputType.h (right):

https://codereview.chromium.org/1798043002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/forms/RadioInputType.h:60: CORE_EXPORT
HTMLElement* nextElement(const HTMLElement&, HTMLFormElement* stayWithin, bool
forward);
I don't want to expose nextElement().  I'd like to move
AXRadioInput::findNextRadioButtonInGroup to RadioInputType as a static function.

[je_julie(Not used), 2016-03-15 10:38:19]

Patchset #2 (id:20001) has been deleted

[je_julie(Not used), 2016-03-15 14:35:16]

On 2016/03/14 23:30:14, tkent wrote:
>
https://codereview.chromium.org/1798043002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/html/forms/RadioInputType.h (right):
> 
>
https://codereview.chromium.org/1798043002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/html/forms/RadioInputType.h:60: CORE_EXPORT
> HTMLElement* nextElement(const HTMLElement&, HTMLFormElement* stayWithin, bool
> forward);
> I don't want to expose nextElement().  I'd like to move
> AXRadioInput::findNextRadioButtonInGroup to RadioInputType as a static
function.

I updated patchset as you suggested. PTAL.

[je_julie(Not used), 2016-03-15 14:38:13]

Description was changed from

==========
Removed CORE_EXPORT from APIs at NodeTraversal.

CORE_EXPORT was added at crrev.com/1628283002 and it caused performance
degrade on traversing dom.
This patch makes AXRadioInput use nextElement at RadioInputType to avoid
using dom traversing APIs directly.

BUG=592282
==========

to

==========
Removed CORE_EXPORT from APIs at NodeTraversal.

CORE_EXPORT was added at crrev.com/1628283002 and it caused performance
degrade on traversing dom.
This patch adds nextRadioButtonInGroup at RadioInputType and makes
AXRadioInput use it to avoid using dom traversing APIs directly.

BUG=592282
==========

[tkent, 2016-03-15 22:30:26]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-03-15 22:30:27]

lgtm

[commit-bot: I haz the power, 2016-03-15 22:30:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1798043002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1798043002/40001

[commit-bot: I haz the power, 2016-03-16 00:47:20]

Description was changed from

==========
Removed CORE_EXPORT from APIs at NodeTraversal.

CORE_EXPORT was added at crrev.com/1628283002 and it caused performance
degrade on traversing dom.
This patch adds nextRadioButtonInGroup at RadioInputType and makes
AXRadioInput use it to avoid using dom traversing APIs directly.

BUG=592282
==========

to

==========
Removed CORE_EXPORT from APIs at NodeTraversal.

CORE_EXPORT was added at crrev.com/1628283002 and it caused performance
degrade on traversing dom.
This patch adds nextRadioButtonInGroup at RadioInputType and makes
AXRadioInput use it to avoid using dom traversing APIs directly.

BUG=592282
==========

[commit-bot: I haz the power, 2016-03-16 00:47:22]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-03-16 00:48:19]

Description was changed from

==========
Removed CORE_EXPORT from APIs at NodeTraversal.

CORE_EXPORT was added at crrev.com/1628283002 and it caused performance
degrade on traversing dom.
This patch adds nextRadioButtonInGroup at RadioInputType and makes
AXRadioInput use it to avoid using dom traversing APIs directly.

BUG=592282
==========

to

==========
Removed CORE_EXPORT from APIs at NodeTraversal.

CORE_EXPORT was added at crrev.com/1628283002 and it caused performance
degrade on traversing dom.
This patch adds nextRadioButtonInGroup at RadioInputType and makes
AXRadioInput use it to avoid using dom traversing APIs directly.

BUG=592282

Committed: https://crrev.com/d420eecfc4f7881986bfbc623c3598a0b72c06c9
Cr-Commit-Position: refs/heads/master@{#381371}
==========

[commit-bot: I haz the power, 2016-03-16 00:48:21]

Patchset 2 (id:??) landed as
https://crrev.com/d420eecfc4f7881986bfbc623c3598a0b72c06c9
Cr-Commit-Position: refs/heads/master@{#381371}