Issue 179793007: Always use the observer's index in ObserverList.removeObserver().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 179793007: Always use the observer's index in ObserverList.removeObserver(). (Closed)

Created:
6 years, 9 months ago by mlamouri (slow - plz ping)

Modified:
6 years, 9 months ago

Reviewers:
Yaron

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@observerlist_returns_boolean

Visibility:
Public.

Always use the observer's index in ObserverList.removeObserver(). BUG=349925 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255924

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	base/android/java/src/org/chromium/base/ObserverList.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

mlamouri (slow - plz ping)

The CQ bit was checked by mlamouri@chromium.org

6 years, 9 months ago (2014-03-10 09:51:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/179793007/1

6 years, 9 months ago (2014-03-10 09:51:10 UTC) #4

Message was sent while issue was closed.

Change committed as 255924