Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 1797843002: Fix flash font file so it can be generated (Closed)

Created:
4 years, 9 months ago by raymes
Modified:
4 years, 9 months ago
Reviewers:
bbudge
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the PPB_Flash_Font_file thunk so it can be generated A change to the PPB_Flash_Font_file thunk made it not able to be generated. This fixes it by adding a shared class which the generator expects to be there. BUG=593205 Committed: https://crrev.com/3d0c88b74fd4f06a5681abf38a8ce3670344f411 Cr-Commit-Position: refs/heads/master@{#382237}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M ppapi/ppapi_shared.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/shared_impl/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A ppapi/shared_impl/ppb_flash_font_file_shared.h View 1 chunk +19 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_flash_font_file_thunk.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
raymes
4 years, 9 months ago (2016-03-17 04:37:42 UTC) #3
bbudge
lgtm
4 years, 9 months ago (2016-03-19 18:48:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1797843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1797843002/1
4 years, 9 months ago (2016-03-20 21:52:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-20 23:51:46 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-20 23:52:50 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d0c88b74fd4f06a5681abf38a8ce3670344f411
Cr-Commit-Position: refs/heads/master@{#382237}

Powered by Google App Engine
This is Rietveld 408576698