Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: runtime/vm/intermediate_language.h

Issue 17977002: - Remove arguments definition test from the VM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language.h
===================================================================
--- runtime/vm/intermediate_language.h (revision 24474)
+++ runtime/vm/intermediate_language.h (working copy)
@@ -523,7 +523,6 @@
M(Branch) \
M(AssertAssignable) \
M(AssertBoolean) \
- M(ArgumentDefinitionTest) \
M(CurrentContext) \
M(StoreContext) \
M(ClosureCall) \
@@ -2514,42 +2513,6 @@
};
-class ArgumentDefinitionTestInstr : public TemplateDefinition<1> {
- public:
- ArgumentDefinitionTestInstr(ArgumentDefinitionTestNode* node,
- Value* saved_arguments_descriptor)
- : ast_node_(*node) {
- SetInputAt(0, saved_arguments_descriptor);
- }
-
- DECLARE_INSTRUCTION(ArgumentDefinitionTest)
- virtual CompileType ComputeType() const;
-
- intptr_t token_pos() const { return ast_node_.token_pos(); }
- intptr_t formal_parameter_index() const {
- return ast_node_.formal_parameter_index();
- }
- const String& formal_parameter_name() const {
- return ast_node_.formal_parameter_name();
- }
-
- Value* saved_arguments_descriptor() const { return inputs_[0]; }
-
- virtual void PrintOperandsTo(BufferFormatter* f) const;
-
- virtual bool CanDeoptimize() const { return true; }
-
- virtual EffectSet Effects() const { return EffectSet::None(); }
-
- virtual bool MayThrow() const { return true; }
-
- private:
- const ArgumentDefinitionTestNode& ast_node_;
-
- DISALLOW_COPY_AND_ASSIGN(ArgumentDefinitionTestInstr);
-};
-
-
// Denotes the current context, normally held in a register. This is
// a computation, not a value, because it's mutable.
class CurrentContextInstr : public TemplateDefinition<0> {

Powered by Google App Engine
This is Rietveld 408576698