[New multicol] Make -webkit-column-break-inside:avoid work.

[New multicol] Make -webkit-column-break-inside:avoid work.

adjustForUnsplittableChild() simply forgot to check whether we
were inside flow thread based multicol, which kept it from even
considering what -webkit-column-break-inside was set to in such cases.

BUG=346661
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167882

[eseidel, 2014-02-25 20:46:00]

Can you add a bit more description to explain why?

[mstensho (USE GERRIT), 2014-02-25 20:54:38]

On 2014/02/25 20:46:15, eseidel wrote:

[mstensho (USE GERRIT), 2014-02-25 21:04:04]

Sorry, :) what I meant to say: is it better now?

When adding support for column breaks in the new multicol implementation I
forgot about break-inside. Actually I thought support for it was completely
missing in Blink, but it's there (although not spec-compliant); it just wasn't
hooked up with the new multicol implementation.

[eseidel, 2014-02-26 00:09:04]

lgtm

https://codereview.chromium.org/179763003/diff/1/LayoutTests/fast/multicol/ne...
File LayoutTests/fast/multicol/newmulticol/avoid-column-break-inside.html
(right):

https://codereview.chromium.org/179763003/diff/1/LayoutTests/fast/multicol/ne...
LayoutTests/fast/multicol/newmulticol/avoid-column-break-inside.html:12: <div
style="-webkit-columns:4; columns:4;">
In general I think we can start to remove all these -webkit- prefixes from our
tests.  They shouldn't be needed.

[commit-bot: I haz the power, 2014-02-26 00:09:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mstensho@opera.com/179763003/1

[mstensho (USE GERRIT), 2014-02-26 00:19:43]

https://codereview.chromium.org/179763003/diff/1/LayoutTests/fast/multicol/ne...
File LayoutTests/fast/multicol/newmulticol/avoid-column-break-inside.html
(right):

https://codereview.chromium.org/179763003/diff/1/LayoutTests/fast/multicol/ne...
LayoutTests/fast/multicol/newmulticol/avoid-column-break-inside.html:12: <div
style="-webkit-columns:4; columns:4;">
On 2014/02/26 00:09:04, eseidel wrote:
> In general I think we can start to remove all these -webkit- prefixes from our
> tests.  They shouldn't be needed.

We cannot do that yet. They are still prefixed in Blink. No unprefixed
alternatives exist yet.

[Paweł Hajdan Jr., 2014-02-26 05:32:35]

The CQ bit was unchecked by phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2014-02-26 05:41:47]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2014-02-26 05:42:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mstensho@opera.com/179763003/1

[commit-bot: I haz the power, 2014-02-26 09:59:18]

Change committed as 167882