third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 1797623003: Fix premature termination of scroll animations while selecting text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1797623003: Fix premature termination of scroll animations while selecting text. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/scroll-behavior/smooth-scroll/scroll-during-selection-expected.txt ('k') | third_party/WebKit/Source/core/frame/RootFrameViewport.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index 69dcfa20d7352261d3bc6e30e1e5834bf8881b5c..bc81e5d688e772c706d65338fc87237fc5c3ee69 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -3735,11 +3735,8 @@ LayoutRect FrameView::scrollIntoView(const LayoutRect& rectInContent, const Scro

{

LayoutRect viewRect(visibleContentRect());

LayoutRect exposeRect = ScrollAlignment::getRectToExpose(viewRect, rectInContent, alignX, alignY);

- double xOffset = exposeRect.x();

- double yOffset = exposeRect.y();

- setScrollPosition(DoublePoint(xOffset, yOffset), scrollType);

+ if (exposeRect != viewRect)

+ setScrollPosition(DoublePoint(exposeRect.x(), exposeRect.y()), scrollType);

// Scrolling the FrameView cannot change the input rect's location relative to the document.

return rectInContent;