Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 179743004: Cast: Enable raw events and stats logging in CastSessionDelegate and sender app (Closed)

Created:
6 years, 10 months ago by imcheng
Modified:
6 years, 9 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, hclam+watch_chromium.org, mikhal+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, pwestin+watch_google.com, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cast: Enable raw events and stats logging in CastSessionDelegate and sender app The effect of this change is that event subscribers in CastSessionDelegate will start receiving and saving events which will result in a slightly higher memory usage. However once 170063006 is landed, logging can be controlled from JS. (with default = off). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253801

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M chrome/renderer/media/cast_session_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/test/sender.cc View 1 chunk +10 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
imcheng
6 years, 10 months ago (2014-02-25 20:22:18 UTC) #1
Alpha Left Google
On 2014/02/25 20:22:18, imcheng1 wrote: LGTM.
6 years, 10 months ago (2014-02-26 00:50:29 UTC) #2
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 10 months ago (2014-02-27 02:27:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/179743004/20001
6 years, 10 months ago (2014-02-27 02:34:48 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-27 08:20:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-02-27 08:20:23 UTC) #6
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 9 months ago (2014-02-27 08:29:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/179743004/20001
6 years, 9 months ago (2014-02-27 08:29:40 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-02-27 14:15:04 UTC) #9
Message was sent while issue was closed.
Change committed as 253801

Powered by Google App Engine
This is Rietveld 408576698