Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 179743002: DevTools: Display pixel value in Device Emulation (Closed)

Created:
6 years, 10 months ago by Habib Virji
Modified:
6 years, 10 months ago
Reviewers:
tkent, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Display pixel value in Device Emulation Slider generates both oninput and onchange value. R=pfeldman, tkent BUG=346633 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167863

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/devtools/front_end/OverridesView.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Habib Virji
Display changed pixel values in Device Emulation Since slider does not generate change event when ...
6 years, 10 months ago (2014-02-25 12:18:24 UTC) #1
pfeldman
lgtm
6 years, 10 months ago (2014-02-25 16:34:22 UTC) #2
Habib Virji
The CQ bit was checked by habib.virji@samsung.com
6 years, 10 months ago (2014-02-25 16:35:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/179743002/1
6 years, 10 months ago (2014-02-25 16:35:45 UTC) #4
Habib Virji
On 2014/02/25 16:34:22, pfeldman wrote: > lgtm Thanks for the quick review.
6 years, 10 months ago (2014-02-25 16:48:39 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-25 19:50:23 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=14059
6 years, 10 months ago (2014-02-25 19:50:23 UTC) #7
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 10 months ago (2014-02-26 01:26:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/179743002/1
6 years, 10 months ago (2014-02-26 04:38:45 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-26 08:52:41 UTC) #10
Message was sent while issue was closed. 
Change committed as 167863

Powered by Google App Engine
This is Rietveld 408576698