Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Issue 1797423003: Mark inspector/sources/debugger-ui/function-details.html as NeedsManualRebaseline (Closed)

Created:
4 years, 9 months ago by adamk
Modified:
4 years, 9 months ago
Reviewers:
Yang
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark inspector/sources/debugger-ui/function-details.html as NeedsManualRebaseline This test's output will change after v8 CL https://codereview.chromium.org/1804783002/ rolls into Chromium. It slightly changes the way Scopes are exposed for functions containing 'with' statements. Will rebaseline after the v8 roll. BUG=592353 TBR=yangguo@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/83e1818175112b9a47d4403ade2357ecc1d43329

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/83e1818175112b9a47d4403ade2357ecc1d43329 Cr-Commit-Position: refs/heads/master@{#381307}
4 years, 9 months ago (2016-03-15 20:56:37 UTC) #2
adamk
Committed patchset #1 (id:1) manually as 83e1818175112b9a47d4403ade2357ecc1d43329 (presubmit successful).
4 years, 9 months ago (2016-03-15 20:57:23 UTC) #4
Yang
4 years, 9 months ago (2016-03-15 21:00:38 UTC) #5
Message was sent while issue was closed.
On 2016/03/15 20:57:23, adamk wrote:
> Committed patchset #1 (id:1) manually as
> 83e1818175112b9a47d4403ade2357ecc1d43329 (presubmit successful).

lgtm

Powered by Google App Engine
This is Rietveld 408576698