Connect MojoAudioDecoder to the service

media/mojo/services/mojo_audio_decoder.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/mojo/services/mojo_audio_decoder.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/single_thread_task_runner.h"
 #include "base/thread_task_runner_handle.h"
 
 namespace media {
 
-MojoAudioDecoder::MojoAudioDecoder() {
+MojoAudioDecoder::MojoAudioDecoder(
+    scoped_refptr<base::SingleThreadTaskRunner> task_runner,
+    interfaces::AudioDecoderPtr remote_decoder)
+    : task_runner_(task_runner), remote_decoder_(std::move(remote_decoder)) {
   DVLOG(1) << __FUNCTION__;
 }
 
 MojoAudioDecoder::~MojoAudioDecoder() {
   DVLOG(1) << __FUNCTION__;
 }
 
 std::string MojoAudioDecoder::GetDisplayName() const {
   return "MojoAudioDecoder";
 }
 
 void MojoAudioDecoder::Initialize(const AudioDecoderConfig& config,
                                   CdmContext* cdm_context,
                                   const InitCB& init_cb,
                                   const OutputCB& output_cb) {
   DVLOG(1) << __FUNCTION__;
   task_runner_ = base::ThreadTaskRunnerHandle::Get();

[sandersd (OOO until July 31), 2016/03/17 20:24:07]

The task_runner_ is discarded here. If this works (ie. the constructor thread is
the correct thread), why pass a task runner at all?

If this is a bug, another alternative is to require the caller to bind the
callbacks to the correct loop themselves. Do we have a reason to pick one
solution over the other?

[xhwang, 2016/03/17 20:26:25]

Good catch. This seems a bug. We should probably always use the |task_runner|
passed in the ctor.

[xhwang, 2016/03/17 20:27:26]

Also, this class should be single threaded. We should check that we are on
|task_runner_| in every call.

[Tima Vaisburd, 2016/03/17 20:31:24]

This is a bug, thank you.
I meant to use the task_runner from ctor that originates in
https://code.google.com/p/chromium/codesearch#chromium/src/media/renderers/de...

I think we want to respect this parameter?

[Tima Vaisburd, 2016/03/17 20:39:57]

Done.

[Tima Vaisburd, 2016/03/17 20:39:58]

Done.

[xhwang, 2016/03/17 20:48:11]

Yes, that's the media task runner we have. All our decoders should run on it.

 
   NOTIMPLEMENTED();
 
   // Pretend to be able to decode anything.
   task_runner_->PostTask(FROM_HERE, base::Bind(init_cb, true));
 }
 
 void MojoAudioDecoder::Decode(const scoped_refptr<DecoderBuffer>& buffer,
                               const DecodeCB& decode_cb) {
   DVLOG(3) << __FUNCTION__;
   NOTIMPLEMENTED();
 
   // Actually we can't decode anything.
   task_runner_->PostTask(FROM_HERE, base::Bind(decode_cb, kDecodeError));
 }
 
 void MojoAudioDecoder::Reset(const base::Closure& closure) {
   DVLOG(2) << __FUNCTION__;
   NOTIMPLEMENTED();
 }
 
 bool MojoAudioDecoder::NeedsBitstreamConversion() const {
   DVLOG(1) << __FUNCTION__;
   NOTIMPLEMENTED();
   return false;
 }
 
 }  // namespace media