Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1797383003: Ensure ChildProcessCreationParams are passed before loading native code (Closed)

Created:
4 years, 9 months ago by mnaganov (inactive)
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure ChildProcessCreationParams are passed before loading native code If Chrome starts without child services pre-warming, ChildProcessLauncher is not getting the special binding flag, and this causes child service creation failure. BUG=592722, 593250 Committed: https://crrev.com/b5022da0db55451ec2f7f77230a385ca0ff4bd81 Cr-Commit-Position: refs/heads/master@{#381519}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mnaganov (inactive)
Hi David, another little change for the service binding fixing a crash.
4 years, 9 months ago (2016-03-16 01:14:23 UTC) #2
mnaganov (inactive)
David, ping!
4 years, 9 months ago (2016-03-16 17:46:38 UTC) #3
David Trainor- moved to gerrit
lgtm
4 years, 9 months ago (2016-03-16 18:25:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1797383003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1797383003/1
4 years, 9 months ago (2016-03-16 18:26:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 20:23:59 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 20:25:23 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5022da0db55451ec2f7f77230a385ca0ff4bd81
Cr-Commit-Position: refs/heads/master@{#381519}

Powered by Google App Engine
This is Rietveld 408576698