content/browser/frame_host/navigator_impl.cc - Issue 1797363002: "Top Document Isolation" mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 1797363002: "Top Document Isolation" mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Two new browsertests. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigator_impl.cc

diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc

index 79265e443d7fefbb85301a8ce7ca4ad25c37eb0d..2dece9275ea7e2a5681d39a065c93cdcc558a67c 100644

--- a/content/browser/frame_host/navigator_impl.cc

+++ b/content/browser/frame_host/navigator_impl.cc

@@ -502,6 +502,8 @@ void NavigatorImpl::DidNavigate(

SiteInstanceImpl* site_instance = render_frame_host->GetSiteInstance();

if (!site_instance->HasSite() &&

ShouldAssignSiteForURL(params.url)) {

+ // TODO(nick): Is it ever necessary to set the third_party_subframe bit

+ // here?

site_instance->SetSite(params.url);

}