"Top Document Isolation" mode

content/browser/site_instance_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/site_instance_impl.h"
 
 #include "content/browser/browsing_instance.h"
 #include "content/browser/child_process_security_policy_impl.h"
 #include "content/browser/frame_host/debug_urls.h"
 #include "content/browser/frame_host/frame_tree_node.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
 #include "content/browser/storage_partition_impl.h"
 #include "content/common/site_isolation_policy.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/render_process_host_factory.h"
 #include "content/public/browser/web_ui_controller_factory.h"
 #include "content/public/common/url_constants.h"
 #include "net/base/registry_controlled_domains/registry_controlled_domain.h"
 
 namespace content {
 
 const RenderProcessHostFactory*
     SiteInstanceImpl::g_render_process_host_factory_ = NULL;
 int32_t SiteInstanceImpl::next_site_instance_id_ = 1;
 
 SiteInstanceImpl::SiteInstanceImpl(BrowsingInstance* browsing_instance)
-    : id_(next_site_instance_id_++),
-      active_frame_count_(0),
-      browsing_instance_(browsing_instance),
-      process_(NULL),
-      has_site_(false) {
+    : id_(next_site_instance_id_++), browsing_instance_(browsing_instance) {
   DCHECK(browsing_instance);
 }
 
 SiteInstanceImpl::~SiteInstanceImpl() {
   GetContentClient()->browser()->SiteInstanceDeleting(this);
 
   if (process_)
     process_->RemoveObserver(this);
 
   // Now that no one is referencing us, we can safely remove ourselves from
@@ skipping 103 matching lines @@
   // Remember that this SiteInstance has been used to load a URL, even if the
   // URL is invalid.
   has_site_ = true;
   BrowserContext* browser_context = browsing_instance_->browser_context();
   site_ = GetSiteForURL(browser_context, url);
 
   // Now that we have a site, register it with the BrowsingInstance.  This
   // ensures that we won't create another SiteInstance for this site within
   // the same BrowsingInstance, because all same-site pages within a
   // BrowsingInstance can script each other.
   browsing_instance_->RegisterSiteInstance(this);

[Charlie Reis, 2016/03/18 21:15:13]

Maybe BI ignores this call for the subframe SI?

 
   if (process_) {
     LockToOrigin();
 
     // Ensure the process is registered for this site if necessary.
     if (RenderProcessHost::ShouldUseProcessPerSite(browser_context, site_)) {
       RenderProcessHostImpl::RegisterProcessHostForSite(
           browser_context, process_, site_);
     }
   }
@@ skipping 38 matching lines @@
   if (IsRendererDebugURL(url))
     return false;
 
   // If the site URL is an extension (e.g., for hosted apps or WebUI) but the
   // process is not (or vice versa), make sure we notice and fix it.
   GURL site_url = GetSiteForURL(browsing_instance_->browser_context(), url);
   return !RenderProcessHostImpl::IsSuitableHost(
       GetProcess(), browsing_instance_->browser_context(), site_url);
 }
 
+SiteInstance* SiteInstanceImpl::GetRelatedSiteInstanceForThirdPartySubframes(
+    const GURL& url) {
+  return browsing_instance_->GetSiteInstanceForThirdPartySubframes(url);
+}
+
 bool SiteInstanceImpl::RequiresDedicatedProcess() {
   if (!has_site_)
     return false;
-  return SiteInstanceImpl::DoesSiteRequireDedicatedProcess(GetBrowserContext(),
-                                                           site_);
+
+  if (DoesSiteRequireDedicatedProcess(GetBrowserContext(), site_))
+    return true;
+
+  if (!is_for_third_party_subframes() &&
+      SiteIsolationPolicy::UseDedicatedProcessForTopDocument()) {

[Charlie Reis, 2016/03/18 21:15:13]

Might not need this.

+    return true;
+  }
+
+  return false;
 }
 
 void SiteInstanceImpl::IncrementActiveFrameCount() {
   active_frame_count_++;
 }
 
 void SiteInstanceImpl::DecrementActiveFrameCount() {
   if (--active_frame_count_ == 0)
     FOR_EACH_OBSERVER(Observer, observers_, ActiveFrameCountIsZero(this));
 }
@@ skipping 143 matching lines @@
           browser_context, effective_url)) {
     return true;
   }
 
   return false;
 }
 
 void SiteInstanceImpl::RenderProcessHostDestroyed(RenderProcessHost* host) {
   DCHECK_EQ(process_, host);
   process_->RemoveObserver(this);
-  process_ = NULL;
+  process_ = nullptr;
 }
 
 void SiteInstanceImpl::RenderProcessWillExit(RenderProcessHost* host) {
   // TODO(nick): http://crbug.com/575400 - RenderProcessWillExit might not serve
   // any purpose here.
   FOR_EACH_OBSERVER(Observer, observers_, RenderProcessGone(this));
 }
 
 void SiteInstanceImpl::RenderProcessExited(RenderProcessHost* host,
                                            base::TerminationStatus status,
@@ skipping 29 matching lines @@
             browsing_instance_->browser_context(), site_))
       return;
 
     ChildProcessSecurityPolicyImpl* policy =
         ChildProcessSecurityPolicyImpl::GetInstance();
     policy->LockToOrigin(process_->GetID(), site_);
   }
 }
 
 }  // namespace content