Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1797323002: [iOS] Use output_name to configure the application name in "app" template. (Closed)

Created:
4 years, 9 months ago by sdefresne
Modified:
4 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@assert_no_deps
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Use output_name to configure the application name in "app" template. BUG=297668 Committed: https://crrev.com/34cfc871f7a7d168b33d32e7297cd86409c6001a Cr-Commit-Position: refs/heads/master@{#381934}

Patch Set 1 #

Patch Set 2 : Rebase on origin/master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M build/config/ios/rules.gni View 1 8 chunks +11 lines, -11 lines 0 comments Download
M ios/web/shell/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
sdefresne
Please take a look.
4 years, 9 months ago (2016-03-15 15:45:51 UTC) #2
brettw
Heh, this might need to be updated when your other patch lands. LGTM
4 years, 9 months ago (2016-03-15 18:04:58 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1797323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1797323002/1
4 years, 9 months ago (2016-03-17 12:43:21 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/5641) ios_rel_device_ninja on ...
4 years, 9 months ago (2016-03-17 12:45:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1797323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1797323002/40001
4 years, 9 months ago (2016-03-18 10:13:03 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 9 months ago (2016-03-18 11:06:14 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 11:07:33 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/34cfc871f7a7d168b33d32e7297cd86409c6001a
Cr-Commit-Position: refs/heads/master@{#381934}

Powered by Google App Engine
This is Rietveld 408576698