Add a histogram (Net.PacResultForStrippedUrl) that estimates how often PAC scripts depend on the UR…

net/proxy/proxy_resolver_v8_tracing.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_PROXY_PROXY_RESOLVER_V8_TRACING_H_
 #define NET_PROXY_PROXY_RESOLVER_V8_TRACING_H_
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 71 matching lines @@
       scoped_ptr<ProxyResolverV8Tracing>* resolver,
       const CompletionCallback& callback,
       scoped_ptr<ProxyResolverFactory::Request>* request) = 0;
 
   static scoped_ptr<ProxyResolverV8TracingFactory> Create();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ProxyResolverV8TracingFactory);
 };
 
+// TODO(eroman): Remove when done gathering data for crbug.com/593759

[Mark P, 2016/03/18 21:34:50]

Please put the standard warning here that these metrics are emitted to UMA and
cannot be changed or renumbered or deleted and new entries should go at the end.

[eroman, 2016/03/18 23:15:16]

Done

+enum class PacResultForStrippedUrl {
+  // Did NOT measure the impact of running FindProxyForURL() with a modified
+  // URL path, because the original URL could not complete using the
+  // non-blocking DNS mode.
+  SKIPPED_FALLBACK_BLOCKING_DNS = 0,
+
+  // The result of running FindProxyForURL() with a modified URL path appears
+  // to be indistinguishable. (Although there may have been sideffects to the
+  // script state that won't manifest until later invocations).
+  SUCCESS = 1,
+
+  // Calling FindProxyForURL() with a modified URL path returned the same proxy
+  // list, but had measurable sideffects in calls to alert().
+  SUCCESS_DIFFERENT_ALERTS = 2,
+
+  // Calling FindProxyForURL() with a modified URL path returned the same proxy
+  // list, but invoked a different sequence of DNS resolutions. This would
+  // require a rather unusual script to trigger.
+  SUCCESS_DIFFERENT_NUM_DNS = 3,
+
+  // Calling FindProxyForURL() with a modified URL path resulted in a different
+  // set of DNS dependencies.
+  FAIL_ABANDONED = 4,
+
+  // Calling FindProxyForURL() with a modified URL path caused a different
+  // execution flow. Whereas with the original URL it succeeded with
+  // non-blocking DNS, this attempt requires fallback to blocking DNS (and was
+  // not attempted).
+  FAIL_FALLBACK_BLOCKING_DNS = 5,
+
+  // Calling FindProxyForURL() with a modified URL path caused a script error.
+  FAIL_ERROR = 6,
+
+  // Calling FindProxyForURL() with a modified URL path returned a different
+  // proxy list.
+  FAIL_DIFFERENT_PROXY_LIST = 7,
+
+  MAX_VALUE,
+};
+
+// TODO(eroman): Remove when done gathering data for crbug.com/593759
+extern NET_EXPORT_PRIVATE const char kHistogramPacResultForStrippedUrl[];
+
 }  // namespace net
 
 #endif  // NET_PROXY_PROXY_RESOLVER_V8_TRACING_H_