Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1797283002:
Define OS=mac in gyp when building mac tools on iOS (Closed)
DescriptionDefine OS=mac in gyp when building mac tools on iOS
The CL https://codereview.chromium.org/1771173002/ introduced a
cycle in gyp files, which is not allowed on iOS:
Cycle: ui/base/ui_base.gyp -> ui/base/ime/ui_base_ime.gyp -> ui/base/ui_base.gyp
This cycle is not actually real on iOS, as it is under a OS!=iOS condition,
It was detected because, when building the mac tools,
gyp_chromium was invoked with OS=iOS.
This OS configuration was internally discarded when actually building
(because of the --ignore-environment flag that was passed), but
was still triggering the check for circular gyp dependencies.
TBR=thakis
Committed: https://crrev.com/a5430a08444415e4a7bd3cf15675136bf89eec31
Cr-Commit-Position: refs/heads/master@{#381248}
Patch Set 1 #
Messages
Total messages: 25 (13 generated)
Description was changed from ========== fix BUG= ========== to ========== Define OS=mac in gyp when building mac tools on iOS The CL https://codereview.chromium.org/1771173002/ introduced a cycle in gyp files, which is not allowed on iOS. This cycle is not actually real on iOS, as it is under a OS!=iOS condition, It was detected because, when building the mac tools, gyp_chromium was invoked with OS=iOS. This OS configuration was internally discarded when actually building (because of the --ignore_environment flag that was passed), but was still triggering the check for circular gyp dependencies. BUG= ==========
Description was changed from ========== Define OS=mac in gyp when building mac tools on iOS The CL https://codereview.chromium.org/1771173002/ introduced a cycle in gyp files, which is not allowed on iOS. This cycle is not actually real on iOS, as it is under a OS!=iOS condition, It was detected because, when building the mac tools, gyp_chromium was invoked with OS=iOS. This OS configuration was internally discarded when actually building (because of the --ignore_environment flag that was passed), but was still triggering the check for circular gyp dependencies. BUG= ========== to ========== Define OS=mac in gyp when building mac tools on iOS The CL https://codereview.chromium.org/1771173002/ introduced a cycle in gyp files, which is not allowed on iOS: Cycle: ui/base/ui_base.gyp -> ui/base/ime/ui_base_ime.gyp -> ui/base/ui_base.gyp gyp: Call to 'cd ../../.. && build/gyp_chromium "--depth=." --ignore-environment "--format=ninja" "-Goutput_dir=xcodebuild/ninja-localizable_string_tool" "-Ddisable_nacl=1" "-Dmac_sdk=10.10" "-Dparent_generator=xcode" ios_internal/chrome/tools/project_localizable_string_tool.gyp' returned exit status 1 while in /b/build/slave/simulator-builder/build/src/ios_internal/chrome/tools/project_localizable_string_tool.gyp. Error: Command '/usr/bin/python src/build/gyp_chromium' returned non-zero exit status 1 in /b/build/slave/simulator-builder/build This cycle is not actually real on iOS, as it is under a OS!=iOS condition, It was detected because, when building the mac tools, gyp_chromium was invoked with OS=iOS. This OS configuration was internally discarded when actually building (because of the --ignore_environment flag that was passed), but was still triggering the check for circular gyp dependencies. BUG= ==========
Description was changed from ========== Define OS=mac in gyp when building mac tools on iOS The CL https://codereview.chromium.org/1771173002/ introduced a cycle in gyp files, which is not allowed on iOS: Cycle: ui/base/ui_base.gyp -> ui/base/ime/ui_base_ime.gyp -> ui/base/ui_base.gyp gyp: Call to 'cd ../../.. && build/gyp_chromium "--depth=." --ignore-environment "--format=ninja" "-Goutput_dir=xcodebuild/ninja-localizable_string_tool" "-Ddisable_nacl=1" "-Dmac_sdk=10.10" "-Dparent_generator=xcode" ios_internal/chrome/tools/project_localizable_string_tool.gyp' returned exit status 1 while in /b/build/slave/simulator-builder/build/src/ios_internal/chrome/tools/project_localizable_string_tool.gyp. Error: Command '/usr/bin/python src/build/gyp_chromium' returned non-zero exit status 1 in /b/build/slave/simulator-builder/build This cycle is not actually real on iOS, as it is under a OS!=iOS condition, It was detected because, when building the mac tools, gyp_chromium was invoked with OS=iOS. This OS configuration was internally discarded when actually building (because of the --ignore_environment flag that was passed), but was still triggering the check for circular gyp dependencies. BUG= ========== to ========== Define OS=mac in gyp when building mac tools on iOS The CL https://codereview.chromium.org/1771173002/ introduced a cycle in gyp files, which is not allowed on iOS: Cycle: ui/base/ui_base.gyp -> ui/base/ime/ui_base_ime.gyp -> ui/base/ui_base.gyp gyp: Call to 'cd ../../.. && build/gyp_chromium "--depth=." --ignore-environment "--format=ninja" "-Goutput_dir=xcodebuild/ninja-localizable_string_tool" "-Ddisable_nacl=1" "-Dmac_sdk=10.10" "-Dparent_generator=xcode" ios_internal/chrome/tools/project_localizable_string_tool.gyp' returned exit status 1 while in /b/build/slave/simulator-builder/build/src/ios_internal/chrome/tools/project_localizable_string_tool.gyp. Error: Command '/usr/bin/python src/build/gyp_chromium' returned non-zero exit status 1 in /b/build/slave/simulator-builder/build This cycle is not actually real on iOS, as it is under a OS!=iOS condition, It was detected because, when building the mac tools, gyp_chromium was invoked with OS=iOS. This OS configuration was internally discarded when actually building (because of the --ignore-environment flag that was passed), but was still triggering the check for circular gyp dependencies. BUG= ==========
droger@chromium.org changed reviewers: + sdefresne@chromium.org
Description was changed from ========== Define OS=mac in gyp when building mac tools on iOS The CL https://codereview.chromium.org/1771173002/ introduced a cycle in gyp files, which is not allowed on iOS: Cycle: ui/base/ui_base.gyp -> ui/base/ime/ui_base_ime.gyp -> ui/base/ui_base.gyp gyp: Call to 'cd ../../.. && build/gyp_chromium "--depth=." --ignore-environment "--format=ninja" "-Goutput_dir=xcodebuild/ninja-localizable_string_tool" "-Ddisable_nacl=1" "-Dmac_sdk=10.10" "-Dparent_generator=xcode" ios_internal/chrome/tools/project_localizable_string_tool.gyp' returned exit status 1 while in /b/build/slave/simulator-builder/build/src/ios_internal/chrome/tools/project_localizable_string_tool.gyp. Error: Command '/usr/bin/python src/build/gyp_chromium' returned non-zero exit status 1 in /b/build/slave/simulator-builder/build This cycle is not actually real on iOS, as it is under a OS!=iOS condition, It was detected because, when building the mac tools, gyp_chromium was invoked with OS=iOS. This OS configuration was internally discarded when actually building (because of the --ignore-environment flag that was passed), but was still triggering the check for circular gyp dependencies. BUG= ========== to ========== Define OS=mac in gyp when building mac tools on iOS The CL https://codereview.chromium.org/1771173002/ introduced a cycle in gyp files, which is not allowed on iOS: Cycle: ui/base/ui_base.gyp -> ui/base/ime/ui_base_ime.gyp -> ui/base/ui_base.gyp gyp: Call to 'cd ../../.. && build/gyp_chromium "--depth=." --ignore-environment "--format=ninja" "-Goutput_dir=xcodebuild/ninja-localizable_string_tool" "-Ddisable_nacl=1" "-Dmac_sdk=10.10" "-Dparent_generator=xcode" ios_internal/chrome/tools/project_localizable_string_tool.gyp' returned exit status 1 while in /b/build/slave/simulator-builder/build/src/ios_internal/chrome/tools/project_localizable_string_tool.gyp. Error: Command '/usr/bin/python src/build/gyp_chromium' returned non-zero exit status 1 in /b/build/slave/simulator-builder/build This cycle is not actually real on iOS, as it is under a OS!=iOS condition, It was detected because, when building the mac tools, gyp_chromium was invoked with OS=iOS. This OS configuration was internally discarded when actually building (because of the --ignore-environment flag that was passed), but was still triggering the check for circular gyp dependencies. ==========
lgtm
Description was changed from ========== Define OS=mac in gyp when building mac tools on iOS The CL https://codereview.chromium.org/1771173002/ introduced a cycle in gyp files, which is not allowed on iOS: Cycle: ui/base/ui_base.gyp -> ui/base/ime/ui_base_ime.gyp -> ui/base/ui_base.gyp gyp: Call to 'cd ../../.. && build/gyp_chromium "--depth=." --ignore-environment "--format=ninja" "-Goutput_dir=xcodebuild/ninja-localizable_string_tool" "-Ddisable_nacl=1" "-Dmac_sdk=10.10" "-Dparent_generator=xcode" ios_internal/chrome/tools/project_localizable_string_tool.gyp' returned exit status 1 while in /b/build/slave/simulator-builder/build/src/ios_internal/chrome/tools/project_localizable_string_tool.gyp. Error: Command '/usr/bin/python src/build/gyp_chromium' returned non-zero exit status 1 in /b/build/slave/simulator-builder/build This cycle is not actually real on iOS, as it is under a OS!=iOS condition, It was detected because, when building the mac tools, gyp_chromium was invoked with OS=iOS. This OS configuration was internally discarded when actually building (because of the --ignore-environment flag that was passed), but was still triggering the check for circular gyp dependencies. ========== to ========== Define OS=mac in gyp when building mac tools on iOS The CL https://codereview.chromium.org/1771173002/ introduced a cycle in gyp files, which is not allowed on iOS: Cycle: ui/base/ui_base.gyp -> ui/base/ime/ui_base_ime.gyp -> ui/base/ui_base.gyp This cycle is not actually real on iOS, as it is under a OS!=iOS condition, It was detected because, when building the mac tools, gyp_chromium was invoked with OS=iOS. This OS configuration was internally discarded when actually building (because of the --ignore-environment flag that was passed), but was still triggering the check for circular gyp dependencies. ==========
droger@chromium.org changed reviewers: + thakis@chromium.org
+thakis as OWNER
Description was changed from ========== Define OS=mac in gyp when building mac tools on iOS The CL https://codereview.chromium.org/1771173002/ introduced a cycle in gyp files, which is not allowed on iOS: Cycle: ui/base/ui_base.gyp -> ui/base/ime/ui_base_ime.gyp -> ui/base/ui_base.gyp This cycle is not actually real on iOS, as it is under a OS!=iOS condition, It was detected because, when building the mac tools, gyp_chromium was invoked with OS=iOS. This OS configuration was internally discarded when actually building (because of the --ignore-environment flag that was passed), but was still triggering the check for circular gyp dependencies. ========== to ========== Define OS=mac in gyp when building mac tools on iOS The CL https://codereview.chromium.org/1771173002/ introduced a cycle in gyp files, which is not allowed on iOS: Cycle: ui/base/ui_base.gyp -> ui/base/ime/ui_base_ime.gyp -> ui/base/ui_base.gyp This cycle is not actually real on iOS, as it is under a OS!=iOS condition, TBR=thakis It was detected because, when building the mac tools, gyp_chromium was invoked with OS=iOS. This OS configuration was internally discarded when actually building (because of the --ignore-environment flag that was passed), but was still triggering the check for circular gyp dependencies. ==========
TBRing thakis, since this is blocking the Chromium roll on iOS.
Description was changed from ========== Define OS=mac in gyp when building mac tools on iOS The CL https://codereview.chromium.org/1771173002/ introduced a cycle in gyp files, which is not allowed on iOS: Cycle: ui/base/ui_base.gyp -> ui/base/ime/ui_base_ime.gyp -> ui/base/ui_base.gyp This cycle is not actually real on iOS, as it is under a OS!=iOS condition, TBR=thakis It was detected because, when building the mac tools, gyp_chromium was invoked with OS=iOS. This OS configuration was internally discarded when actually building (because of the --ignore-environment flag that was passed), but was still triggering the check for circular gyp dependencies. ========== to ========== Define OS=mac in gyp when building mac tools on iOS The CL https://codereview.chromium.org/1771173002/ introduced a cycle in gyp files, which is not allowed on iOS: Cycle: ui/base/ui_base.gyp -> ui/base/ime/ui_base_ime.gyp -> ui/base/ui_base.gyp This cycle is not actually real on iOS, as it is under a OS!=iOS condition, It was detected because, when building the mac tools, gyp_chromium was invoked with OS=iOS. This OS configuration was internally discarded when actually building (because of the --ignore-environment flag that was passed), but was still triggering the check for circular gyp dependencies. TBR=thakis ==========
The CQ bit was checked by droger@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1797283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1797283002/1
thakis@chromium.org changed reviewers: + justincohen@chromium.org
Hm, that's pretty gnarly. How much longer is this gypi required? Trunk is on ninja now internally too, right?
On 2016/03/15 at 16:58:49, thakis wrote: > Hm, that's pretty gnarly. How much longer is this gypi required? Trunk is on ninja now internally too, right? It's moving to ninja, some bots are still using xcodebuild (and breaking).
lgtm
Message was sent while issue was closed.
Description was changed from ========== Define OS=mac in gyp when building mac tools on iOS The CL https://codereview.chromium.org/1771173002/ introduced a cycle in gyp files, which is not allowed on iOS: Cycle: ui/base/ui_base.gyp -> ui/base/ime/ui_base_ime.gyp -> ui/base/ui_base.gyp This cycle is not actually real on iOS, as it is under a OS!=iOS condition, It was detected because, when building the mac tools, gyp_chromium was invoked with OS=iOS. This OS configuration was internally discarded when actually building (because of the --ignore-environment flag that was passed), but was still triggering the check for circular gyp dependencies. TBR=thakis ========== to ========== Define OS=mac in gyp when building mac tools on iOS The CL https://codereview.chromium.org/1771173002/ introduced a cycle in gyp files, which is not allowed on iOS: Cycle: ui/base/ui_base.gyp -> ui/base/ime/ui_base_ime.gyp -> ui/base/ui_base.gyp This cycle is not actually real on iOS, as it is under a OS!=iOS condition, It was detected because, when building the mac tools, gyp_chromium was invoked with OS=iOS. This OS configuration was internally discarded when actually building (because of the --ignore-environment flag that was passed), but was still triggering the check for circular gyp dependencies. TBR=thakis ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Define OS=mac in gyp when building mac tools on iOS The CL https://codereview.chromium.org/1771173002/ introduced a cycle in gyp files, which is not allowed on iOS: Cycle: ui/base/ui_base.gyp -> ui/base/ime/ui_base_ime.gyp -> ui/base/ui_base.gyp This cycle is not actually real on iOS, as it is under a OS!=iOS condition, It was detected because, when building the mac tools, gyp_chromium was invoked with OS=iOS. This OS configuration was internally discarded when actually building (because of the --ignore-environment flag that was passed), but was still triggering the check for circular gyp dependencies. TBR=thakis ========== to ========== Define OS=mac in gyp when building mac tools on iOS The CL https://codereview.chromium.org/1771173002/ introduced a cycle in gyp files, which is not allowed on iOS: Cycle: ui/base/ui_base.gyp -> ui/base/ime/ui_base_ime.gyp -> ui/base/ui_base.gyp This cycle is not actually real on iOS, as it is under a OS!=iOS condition, It was detected because, when building the mac tools, gyp_chromium was invoked with OS=iOS. This OS configuration was internally discarded when actually building (because of the --ignore-environment flag that was passed), but was still triggering the check for circular gyp dependencies. TBR=thakis Committed: https://crrev.com/a5430a08444415e4a7bd3cf15675136bf89eec31 Cr-Commit-Position: refs/heads/master@{#381248} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a5430a08444415e4a7bd3cf15675136bf89eec31 Cr-Commit-Position: refs/heads/master@{#381248}
Message was sent while issue was closed.
On 2016/03/15 17:01:33, sdefresne wrote: > On 2016/03/15 at 16:58:49, thakis wrote: > > Hm, that's pretty gnarly. How much longer is this gypi required? Trunk is on > ninja now internally too, right? > > It's moving to ninja, some bots are still using xcodebuild (and breaking). When will these be turned down?
Message was sent while issue was closed.
Probably close to the M51 branch. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
