Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1797243002: [iOS/OS X] Add Security.framework to //crypto link flags. (Closed)

Created:
4 years, 9 months ago by sdefresne
Modified:
4 years, 9 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@iossim.deps
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS/OS X] Add Security.framework to //crypto link flags. The //crypto library uses some constants that comes from the Security framework (kSecClassGenericPassword, ...). Add this framework to the list of libraries to link on iOS and OS X. BUG=459705 Committed: https://crrev.com/41b8690712fc10cd4c23778346083910dd3e9104 Cr-Commit-Position: refs/heads/master@{#381746}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M crypto/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
sdefresne
Please take a look.
4 years, 9 months ago (2016-03-15 13:59:03 UTC) #2
Ryan Sleevi
lgtm
4 years, 9 months ago (2016-03-16 23:22:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1797243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1797243002/1
4 years, 9 months ago (2016-03-17 10:31:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/118682)
4 years, 9 months ago (2016-03-17 12:28:21 UTC) #7
sdefresne
Flake, resending to CQ.
4 years, 9 months ago (2016-03-17 13:19:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1797243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1797243002/1
4 years, 9 months ago (2016-03-17 13:19:32 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/118722)
4 years, 9 months ago (2016-03-17 15:27:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1797243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1797243002/1
4 years, 9 months ago (2016-03-17 18:01:35 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 18:09:32 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 18:11:07 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41b8690712fc10cd4c23778346083910dd3e9104
Cr-Commit-Position: refs/heads/master@{#381746}

Powered by Google App Engine
This is Rietveld 408576698