Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 179723005: Remove GDI font rendering code for windows (Closed)

Created:
6 years, 10 months ago by eae
Modified:
6 years, 10 months ago
Reviewers:
dglazkov, dglazkov1
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Remove GDI font rendering code for windows Remove the old windows font rendering code that calls GDI directly as we now go through skia instead. As of M33 the skia code is used for all channels and considered stable. BUG=249099 R=dglazkov@google.com, dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167812

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1280 lines) Patch
M Source/build/features.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/blink_platform.gyp View 2 chunks +7 lines, -23 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/platform/fonts/AlternateFontFamily.h View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/platform/fonts/FontCache.h View 3 chunks +3 lines, -6 lines 0 comments Download
M Source/platform/fonts/FontCache.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/fonts/FontCustomPlatformData.h View 2 chunks +3 lines, -11 lines 0 comments Download
M Source/platform/fonts/skia/FontCacheSkia.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/skia/FontCustomPlatformDataSkia.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/skia/FontPlatformDataSkia.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/platform/fonts/win/FontCacheWin.cpp View 1 chunk +0 lines, -594 lines 0 comments Download
D Source/platform/fonts/win/FontCustomPlatformDataWin.cpp View 1 1 chunk +0 lines, -135 lines 0 comments Download
M Source/platform/fonts/win/FontPlatformDataWin.h View 2 chunks +0 lines, -11 lines 0 comments Download
M Source/platform/fonts/win/FontPlatformDataWin.cpp View 3 chunks +1 line, -53 lines 0 comments Download
D Source/platform/fonts/win/GlyphPageTreeNodeWin.cpp View 1 chunk +0 lines, -261 lines 0 comments Download
D Source/platform/fonts/win/SimpleFontDataWin.cpp View 1 1 chunk +0 lines, -173 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
eae
6 years, 10 months ago (2014-02-25 17:42:58 UTC) #1
dglazkov1
lgtm
6 years, 10 months ago (2014-02-25 17:44:31 UTC) #2
eae
The CQ bit was checked by eae@chromium.org
6 years, 10 months ago (2014-02-25 17:45:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/179723005/20001
6 years, 10 months ago (2014-02-25 17:45:27 UTC) #4
eae
6 years, 10 months ago (2014-02-25 19:10:20 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r167812 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698