Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Issue 179723004: Rebaselines for https://codereview.chromium.org/177963003/ (Closed)

Created:
6 years, 10 months ago by kevin.petit
Modified:
6 years, 10 months ago
Reviewers:
djsollen, mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Rebaselines for https://codereview.chromium.org/177963003/ Signed-off-by: Kévin PETIT <kevin.petit@arm.com>; BUG=skia: NOTRY=true NOTREECHECKS=true Committed: http://code.google.com/p/skia/source/detail?r=13579

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove hairmodes #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -35 lines) Patch
M expectations/gm/Test-Android-Xoom-Tegra2-Arm7-Debug/expected-results.json View 1 chunk +2 lines, -6 lines 0 comments Download
M expectations/gm/Test-Android-Xoom-Tegra2-Arm7-Release/expected-results.json View 1 chunk +2 lines, -6 lines 0 comments Download
M expectations/gm/ignored-tests.txt View 1 2 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
kevin.petit
6 years, 10 months ago (2014-02-25 14:18:01 UTC) #1
djsollen
I don't think you want to rebase the hairmodes as that is part of another ...
6 years, 10 months ago (2014-02-25 14:59:55 UTC) #2
kevin.petit
On 2014/02/25 14:59:55, djsollen wrote: > I don't think you want to rebase the hairmodes ...
6 years, 10 months ago (2014-02-25 16:20:05 UTC) #3
djsollen
lgtm
6 years, 10 months ago (2014-02-25 16:25:29 UTC) #4
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 10 months ago (2014-02-25 16:26:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kevin.petit@arm.com/179723004/20001
6 years, 10 months ago (2014-02-25 16:26:42 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-25 16:26:45 UTC) #7
commit-bot: I haz the power
Failed to apply patch for expectations/gm/ignored-tests.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-25 16:26:46 UTC) #8
djsollen
can you rebase this change? We are trying to clean up the ignored-test file today ...
6 years, 10 months ago (2014-02-25 16:30:27 UTC) #9
kevin.petit
The CQ bit was checked by kevin.petit@arm.com
6 years, 10 months ago (2014-02-25 16:46:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kevin.petit@arm.com/179723004/40001
6 years, 10 months ago (2014-02-25 16:46:12 UTC) #11
kevin.petit
On 2014/02/25 16:30:27, djsollen wrote: > can you rebase this change? We are trying to ...
6 years, 10 months ago (2014-02-25 16:46:14 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-25 16:46:29 UTC) #13
Message was sent while issue was closed.
Change committed as 13579

Powered by Google App Engine
This is Rietveld 408576698