[Findit] Fix bug when display try job result for non-swarming step.

[Findit] Fix bug when display try job result for non-swarming step.

For some non-swarming steps, findit only has step level info, but try job can sometimes provide specific test that failed.

The change will make Findit to look for these tests and add them to the step.


BUG=594191
Committed: https://chromium.googlesource.com/infra/infra/+/37ad2746a474c1cada004c97234deb28005a0b7c

[chanli, 2016-03-14 23:41:49]

chanli@chromium.org changed reviewers:
+ lijeffrey@chromium.org, stgao@chromium.org

[chanli, 2016-03-14 23:41:50]

PTAL.

[stgao, 2016-03-15 17:19:41]

lgtm with nits.


Note: for the tests failed on waterfall bots, we might not get the same list of
tests from try-job unless all the failed tests are reliable failures.

You may consider using test-results.appspot.com to get the list of failed tests
for none-swarming gtests, but in a separate CL.

https://codereview.chromium.org/1797093002/diff/1/appengine/findit/handlers/h...
File appengine/findit/handlers/handlers_util.py (right):

https://codereview.chromium.org/1797093002/diff/1/appengine/findit/handlers/h...
appengine/findit/handlers/handlers_util.py:148: if try_job_culprits.get(step,
{}).get('tests'):
Note: for some script-based test like checklicense which is none-gtest, we might
still have test-level info from try-job.

https://codereview.chromium.org/1797093002/diff/1/appengine/findit/handlers/h...
appengine/findit/handlers/handlers_util.py:194: culprit_info['status'] = 'Flaky'
nit: no hard code here. Use the var at the top.

[chanli, 2016-03-15 17:34:05]

https://codereview.chromium.org/1797093002/diff/1/appengine/findit/handlers/h...
File appengine/findit/handlers/handlers_util.py (right):

https://codereview.chromium.org/1797093002/diff/1/appengine/findit/handlers/h...
appengine/findit/handlers/handlers_util.py:194: culprit_info['status'] = 'Flaky'
On 2016/03/15 17:19:40, stgao wrote:
> nit: no hard code here. Use the var at the top.

Done.

[chanli, 2016-03-15 20:47:32]

The CQ bit was checked by chanli@chromium.org

[chanli, 2016-03-15 20:47:32]

The patchset sent to the CQ was uploaded after l-g-t-m from stgao@chromium.org
Link to the patchset: https://codereview.chromium.org/1797093002/#ps20001
(title: ".")

[commit-bot: I haz the power, 2016-03-15 20:47:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1797093002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1797093002/20001

[commit-bot: I haz the power, 2016-03-15 20:51:02]

Description was changed from

==========
[Findit] Fix bug when display try job result for non-swarming step.

For some non-swarming steps, findit only has step level info, but try job can
sometimes provide specific test that failed.

The change will make Findit to look for these tests and add them to the step.


BUG=594191
==========

to

==========
[Findit] Fix bug when display try job result for non-swarming step.

For some non-swarming steps, findit only has step level info, but try job can
sometimes provide specific test that failed.

The change will make Findit to look for these tests and add them to the step.


BUG=594191

Committed:
https://chromium.googlesource.com/infra/infra/+/37ad2746a474c1cada004c97234de...
==========

[commit-bot: I haz the power, 2016-03-15 20:51:03]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/37ad2746a474c1cada004c97234de...