Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1797053002: Move theme part drawing functions only used on Windows to NativeThemeWin (Closed)

Created:
4 years, 9 months ago by Evan Stade
Modified:
4 years, 9 months ago
Reviewers:
tapted
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move theme part drawing functions only used on Windows to NativeThemeWin Also use the platform-specific color in CommonThemePaintMenuItemBackground This should fix a regression introduced by ff6ab32f0ee2963f BUG=570698 Committed: https://crrev.com/84a503faa847b9193c688fb093c36bc98f0f46f9 Cr-Commit-Position: refs/heads/master@{#381658}

Patch Set 1 #

Patch Set 2 : compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -40 lines) Patch
M ui/native_theme/common_theme.h View 1 chunk +1 line, -9 lines 0 comments Download
M ui/native_theme/common_theme.cc View 2 chunks +4 lines, -26 lines 0 comments Download
M ui/native_theme/native_theme_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/native_theme/native_theme_win.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/native_theme/native_theme_win.cc View 1 3 chunks +29 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1797053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1797053002/1
4 years, 9 months ago (2016-03-14 21:53:35 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/188900)
4 years, 9 months ago (2016-03-14 22:28:19 UTC) #4
Evan Stade
4 years, 9 months ago (2016-03-17 01:05:14 UTC) #6
tapted
lgtm
4 years, 9 months ago (2016-03-17 02:08:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1797053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1797053002/20001
4 years, 9 months ago (2016-03-17 02:52:28 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 03:54:55 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 03:56:03 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/84a503faa847b9193c688fb093c36bc98f0f46f9
Cr-Commit-Position: refs/heads/master@{#381658}

Powered by Google App Engine
This is Rietveld 408576698