Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: components/autofill/core/browser/autofill_metrics.h

Issue 17970003: New encryption/escrow endpoints for Wallet (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated histograms.xml Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_metrics.h
diff --git a/components/autofill/core/browser/autofill_metrics.h b/components/autofill/core/browser/autofill_metrics.h
index 5fde62c2fbe825d97c874cfd4705d0ed130240ab..b90a0b653fc770127ab1ff572fd0f84bc57c84ef 100644
--- a/components/autofill/core/browser/autofill_metrics.h
+++ b/components/autofill/core/browser/autofill_metrics.h
@@ -287,19 +287,16 @@ class AutofillMetrics {
};
// For measuring the network request time of various Wallet API calls. See
- // WalletClient::RequestType.
+ // WalletClient::RequestType. A number of members of this enum have been
+ // deprecated and removed.
Ilya Sherman 2013/07/02 21:40:38 Please keep them in the enum, and pre-pend the ent
Dan Beam 2013/07/02 21:41:35 i suggested just removing them, guess this is the
Dan Beam 2013/07/02 21:42:15 any particular reason for this? just to be less er
Ilya Sherman 2013/07/02 21:49:07 Yep, less error-prone.
ahutter 2013/07/02 21:56:54 Done.
enum WalletApiCallMetric {
UNKNOWN_API_CALL, // Catch all. Should never be used.
ACCEPT_LEGAL_DOCUMENTS,
AUTHENTICATE_INSTRUMENT,
GET_FULL_WALLET,
GET_WALLET_ITEMS,
- SAVE_ADDRESS,
- SAVE_INSTRUMENT,
- SAVE_INSTRUMENT_AND_ADDRESS,
- SEND_STATUS,
- UPDATE_ADDRESS,
- UPDATE_INSTRUMENT,
+ SEND_STATUS = 8,
+ SAVE_TO_WALLET = 11,
};
// For measuring the frequency of errors while communicating with the Wallet

Powered by Google App Engine
This is Rietveld 408576698