Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1796993002: Fix crrev and add test coverage for the main function. (Closed)

Created:
4 years, 9 months ago by qyearsley
Modified:
4 years, 8 months ago
Reviewers:
dnj, RobertoCN, iannucci, prasadv
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Fix crrev and add test coverage for the main function. Specifically, what was broken was a simple typo: json.lad instead of json.load. I didn't catch this before because there was no test coverage for the `main` function. BUG=594605 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M scripts/slave/recipe_modules/crrev/resources/crrev_client.py View 1 chunk +5 lines, -5 lines 0 comments Download
M scripts/slave/recipe_modules/crrev/resources/crrev_client_test.py View 1 chunk +15 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/crrev/resources/test_params_file.json View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (10 generated)
qyearsley
4 years, 9 months ago (2016-03-14 20:23:37 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1796993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1796993002/1
4 years, 9 months ago (2016-03-15 18:03:14 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-15 18:06:45 UTC) #6
qyearsley
On 2016/03/15 at 18:06:45, commit-bot wrote: > Dry run: This issue passed the CQ dry ...
4 years, 9 months ago (2016-03-15 21:01:38 UTC) #7
qyearsley
Ping again
4 years, 9 months ago (2016-03-18 19:49:16 UTC) #8
RobertoCN
lgtm
4 years, 9 months ago (2016-03-23 02:11:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1796993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1796993002/1
4 years, 9 months ago (2016-03-23 02:29:13 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/3271)
4 years, 9 months ago (2016-03-23 02:35:09 UTC) #13
qyearsley
On 2016/03/23 at 02:35:09, commit-bot wrote: > Try jobs failed on following builders: > Build ...
4 years, 9 months ago (2016-03-23 21:14:15 UTC) #16
qyearsley
On 2016/03/23 at 21:14:15, qyearsley wrote: > On 2016/03/23 at 02:35:09, commit-bot wrote: > > ...
4 years, 9 months ago (2016-03-25 21:25:38 UTC) #17
qyearsley
+dnj This is a fix (json.lad -> json.load) with a test to cover the lines ...
4 years, 8 months ago (2016-03-29 16:13:06 UTC) #19
dnj
lgtm
4 years, 8 months ago (2016-03-29 16:25:49 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1796993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1796993002/1
4 years, 8 months ago (2016-03-29 16:29:47 UTC) #22
qyearsley
On 2016/03/29 at 16:25:49, dnj wrote: > lgtm Thanks :-)
4 years, 8 months ago (2016-03-29 16:29:56 UTC) #23
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 16:33:35 UTC) #25
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299538

Powered by Google App Engine
This is Rietveld 408576698