Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 1796963002: NaCl cleanup: Remove ppapi_test_lib from the Scons build (Closed)

Created:
4 years, 9 months ago by Mark Seaborn
Modified:
4 years, 9 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl cleanup: Remove ppapi_test_lib from the Scons build This is no longer used in the Scons build since I removed the Scons-based tests in ppapi/native_client/tests/nacl_browser/browser_dynamic_library/. However, ppapi_test_lib is still used by chrome/test/data/nacl/, by Gyp/GN-built tests. BUG=154400 TEST=nacl_integration on the trybots Committed: https://crrev.com/eea1fa26c3d6fa0bd6e088980f1e55b15660ada9 Cr-Commit-Position: refs/heads/master@{#381076}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M ppapi/native_client/chrome_main.scons View 1 chunk +0 lines, -1 line 0 comments Download
D ppapi/native_client/tests/ppapi_test_lib/nacl.scons View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1796963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1796963002/1
4 years, 9 months ago (2016-03-14 19:08:03 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-14 19:43:00 UTC) #4
Mark Seaborn
4 years, 9 months ago (2016-03-14 19:47:09 UTC) #7
bradn
lgtm
4 years, 9 months ago (2016-03-14 21:23:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1796963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1796963002/1
4 years, 9 months ago (2016-03-14 21:23:59 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-14 21:33:17 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 21:35:29 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eea1fa26c3d6fa0bd6e088980f1e55b15660ada9
Cr-Commit-Position: refs/heads/master@{#381076}

Powered by Google App Engine
This is Rietveld 408576698