test/cctest/interpreter/test-interpreter.cc - Issue 1796893002: [Interpreter] Pops the context to the correct level on return.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/interpreter/test-interpreter.cc

Issue 1796893002: [Interpreter] Pops the context to the correct level on return. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Adds check that break/continue are not seen in top level scope. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/interpreter/bytecode-generator.cc ('K') | « test/cctest/interpreter/bytecode_expectations/WithStatement.golden ('k') | test/mjsunit/ignition/debug-scope-on-return.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/cctest/interpreter/test-interpreter.cc

diff --git a/test/cctest/interpreter/test-interpreter.cc b/test/cctest/interpreter/test-interpreter.cc

index 6644c13cb520002239a6a767930b686c51002632..4de061fcd2a54d3e559d27b313413fe3f3ca8fa4 100644

--- a/test/cctest/interpreter/test-interpreter.cc

+++ b/test/cctest/interpreter/test-interpreter.cc

@@ -2075,6 +2075,15 @@ TEST(InterpreterTryFinally) {

" try { a = 3; throw 23; } finally { a = 4; }"

"} catch(e) { a = a + e; } return a;",

factory->NewStringFromStaticChars("R27")),

+ std::make_pair("var func_name;"

+ "function tcf2(a) {"

+ " try { throw new Error('boom');} "

+ " catch(e) {return 153; } "

+ " finally {func_name = tcf2.name;}"

+ "}"

+ "tcf2();"

+ "return func_name;",

+ factory->NewStringFromStaticChars("Rtcf2")),

};

const char* try_wrapper =