test/cctest/interpreter/bytecode_expectations/BasicLoops.golden - Issue 1796893002: [Interpreter] Pops the context to the correct level on return.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/interpreter/bytecode_expectations/BasicLoops.golden

Issue 1796893002: [Interpreter] Pops the context to the correct level on return. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Adds check that break/continue are not seen in top level scope. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/interpreter/bytecode-generator.cc ('K') | « src/interpreter/bytecode-generator.cc ('k') | test/cctest/interpreter/bytecode_expectations/ContextVariables.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/cctest/interpreter/bytecode_expectations/BasicLoops.golden

diff --git a/test/cctest/interpreter/bytecode_expectations/BasicLoops.golden b/test/cctest/interpreter/bytecode_expectations/BasicLoops.golden

index 531c31bc55fd1b857044e5fe843302ab45f995bd..8ed2484e37545ccbfac778f7cb27e5185ea58cf6 100644

--- a/test/cctest/interpreter/bytecode_expectations/BasicLoops.golden

+++ b/test/cctest/interpreter/bytecode_expectations/BasicLoops.golden

@@ -793,13 +793,13 @@ snippet: "

frame size: 7

parameter count: 1

-bytecode array length: 118

+bytecode array length: 120

bytecodes: [

B(StackCheck),

B(LdaZero),

B(Star), R(1),

B(Ldar), R(1),

- B(JumpIfToBooleanFalse), U8(110),

+ B(JumpIfToBooleanFalse), U8(112),

B(StackCheck),

B(LdaConstant), U8(0),

B(Star), R(4),

@@ -824,9 +824,10 @@ bytecodes: [

B(LdaConstant), U8(3),

B(Star), R(4),

B(CallRuntime), U16(Runtime::kThrowReferenceError), R(4), U8(1),

- B(JumpIfToBooleanFalse), U8(6),

+ B(JumpIfToBooleanFalse), U8(8),

B(PopContext), R(3),

- B(Jump), U8(-67),

+ B(PopContext), R(3),

+ B(Jump), U8(-69),

B(LdaContextSlot), R(context), U8(4),

B(JumpIfNotHole), U8(11),

B(LdaConstant), U8(3),

@@ -844,7 +845,7 @@ bytecodes: [

B(Ldar), R(5),

B(StaContextSlot), R(context), U8(4),

B(PopContext), R(3),

- B(Jump), U8(-110),

+ B(Jump), U8(-112),

B(LdaUndefined),

B(Return),

]