test/cctest/interpreter/bytecode_expectations/WithStatement.golden - Issue 1796893002: [Interpreter] Pops the context to the correct level on return.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/interpreter/bytecode_expectations/WithStatement.golden

Issue 1796893002: [Interpreter] Pops the context to the correct level on return. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Added a test for try-finally with return in test-interpreter. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/interpreter/bytecode-generator.cc ('K') | « test/cctest/interpreter/bytecode_expectations/TryCatch.golden ('k') | test/cctest/interpreter/test-interpreter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/cctest/interpreter/bytecode_expectations/WithStatement.golden

diff --git a/test/cctest/interpreter/bytecode_expectations/WithStatement.golden b/test/cctest/interpreter/bytecode_expectations/WithStatement.golden

index 2d2a61f70524122215b40f8d25991f64b6be510e..8cdc957f6f8e6cded1e3979a7edfc6bd0de436e0 100644

--- a/test/cctest/interpreter/bytecode_expectations/WithStatement.golden

+++ b/test/cctest/interpreter/bytecode_expectations/WithStatement.golden

@@ -13,7 +13,7 @@ snippet: "

frame size: 5

parameter count: 1

-bytecode array length: 45

+bytecode array length: 47

bytecodes: [

B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), U8(1),

B(PushContext), R(0),

@@ -33,6 +33,7 @@ bytecodes: [

B(CallRuntime), U16(Runtime::kPushWithContext), R(3), U8(2),

B(PushContext), R(1),

B(LdaLookupSlot), U8(1),

+ B(PopContext), R(0),

B(Return),

]

constant pool: [