tools/gyp/v8.gyp - Issue 1796863002: Remove snapshot log parsing and option from tools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gyp/v8.gyp

Issue 1796863002: Remove snapshot log parsing and option from tools. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase on master. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gyp/v8.gyp

diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp

index 3bebe9aa70664fef825362623b5014e545757734..8284e7ebef3f4922cd112290261e76f06d1cc851 100644

--- a/tools/gyp/v8.gyp

+++ b/tools/gyp/v8.gyp

@@ -211,10 +211,6 @@

'<(INTERMEDIATE_DIR)/snapshot.cc',

'variables': {

- 'mksnapshot_flags': [

- '--log-snapshot-positions',

- '--logfile', '<(INTERMEDIATE_DIR)/snapshot.log',

- ],

'conditions': [

['v8_random_seed!=0', {

'mksnapshot_flags': ['--random-seed', '<(v8_random_seed)'],

@@ -311,8 +307,6 @@

# variable.

'mksnapshot_flags_ignition': [

'--ignition',

- '--log-snapshot-positions',

- '--logfile', '<(INTERMEDIATE_DIR)/snapshot_ignition.log',

'conditions': [

['v8_random_seed!=0', {

@@ -376,10 +370,6 @@

'action_name': 'run_mksnapshot (external)',

'inputs': ['<(mksnapshot_exec)'],

'variables': {

- 'mksnapshot_flags': [

- '--log-snapshot-positions',

- '--logfile', '<(INTERMEDIATE_DIR)/snapshot.log',

- ],

'conditions': [

['v8_random_seed!=0', {

'mksnapshot_flags': ['--random-seed', '<(v8_random_seed)'],

« no previous file with comments | « test/mjsunit/tools/tickprocessor.js ('k') | tools/ll_prof.py » ('j') | no next file with comments »