Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: src/log.cc

Issue 1796863002: Remove snapshot log parsing and option from tools. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase on master. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/log.h ('k') | src/snapshot/deserializer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/log.cc
diff --git a/src/log.cc b/src/log.cc
index 9c51644b598d8d115bf04aa76ad36711d8127cb3..93111a2e7eba008c025ccc141026cf38e7caf2c5 100644
--- a/src/log.cc
+++ b/src/log.cc
@@ -326,14 +326,6 @@ class LowLevelLogger : public CodeEventLogger {
};
- struct SnapshotPositionStruct {
- static const char kTag = 'P';
-
- Address address;
- int32_t position;
- };
-
-
static const char kCodeMovingGCTag = 'G';
@@ -426,17 +418,6 @@ void LowLevelLogger::CodeMoveEvent(AbstractCode* from, Address to) {
LogWriteStruct(event);
}
-void LowLevelLogger::SnapshotPositionEvent(HeapObject* obj, int pos) {
- if (obj->IsAbstractCode()) {
- SnapshotPositionStruct event;
- event.address =
- obj->address() +
- (obj->IsCode() ? Code::kHeaderSize : BytecodeArray::kHeaderSize);
- event.position = pos;
- LogWriteStruct(event);
- }
-}
-
void LowLevelLogger::LogWriteBytes(const char* bytes, int size) {
size_t rv = fwrite(bytes, 1, size, ll_output_handle_);
@@ -1296,17 +1277,6 @@ void Logger::CodeNameEvent(Address addr, int pos, const char* code_name) {
msg.WriteToLogFile();
}
-void Logger::SnapshotPositionEvent(HeapObject* obj, int pos) {
- if (!log_->IsEnabled()) return;
- LL_LOG(SnapshotPositionEvent(obj, pos));
- if (!FLAG_log_snapshot_positions) return;
- Log::MessageBuilder msg(log_);
- msg.Append("%s,", kLogEventsNames[SNAPSHOT_POSITION_EVENT]);
- msg.AppendAddress(obj->address());
- msg.Append(",%d", pos);
- msg.WriteToLogFile();
-}
-
void Logger::SharedFunctionInfoMoveEvent(Address from, Address to) {
if (!is_logging_code_events()) return;
@@ -1781,11 +1751,6 @@ bool Logger::SetUp(Isolate* isolate) {
if (is_initialized_) return true;
is_initialized_ = true;
- // --ll-prof implies --log-code and --log-snapshot-positions.
- if (FLAG_ll_prof) {
- FLAG_log_snapshot_positions = true;
- }
-
std::ostringstream log_file_name;
PrepareLogFileName(log_file_name, isolate, FLAG_logfile);
log_->Initialize(log_file_name.str().c_str());
« no previous file with comments | « src/log.h ('k') | src/snapshot/deserializer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698