BUILD.gn - Issue 1796863002: Remove snapshot log parsing and option from tools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 1796863002: Remove snapshot log parsing and option from tools. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Remove snapshotLogProcessor leftovers. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index 1a2dce924dcad2b04e6aee9ec29ddf64db5fb0a5..a6bded622440e6a0a14e31a6f4a4db98d8922644 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -509,9 +509,6 @@ action("run_mksnapshot") {

"./" + rebase_path(get_label_info(":mksnapshot($snapshot_toolchain)",

"root_out_dir") + "/mksnapshot",

root_build_dir),

- "--log-snapshot-positions",

- "--logfile",

- rebase_path("$target_gen_dir/snapshot.log", root_build_dir),

Yang 2016/04/05 12:37:13 In src/snapshot/mksnapshot.cc, at the very start o

Stefano Sanfilippo 2016/04/05 14:06:09 Done.

"--startup_src",

rebase_path("$target_gen_dir/snapshot.cc", root_build_dir),

]

« no previous file with comments | « no previous file | src/flag-definitions.h » ('j') | no next file with comments »