BUILD.gn - Issue 1796863002: Remove snapshot log parsing and option from tools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 1796863002: Remove snapshot log parsing and option from tools. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index b872461c7c990d5d369d9caf759f05ea4fa2276e..d72a02822cd176227ab5128ed2d0f4ea2ba14ec5 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -492,8 +492,6 @@ action("run_mksnapshot") {

"root_out_dir") + "/mksnapshot",

root_build_dir),

"--log-snapshot-positions",

- "--logfile",

- rebase_path("$target_gen_dir/snapshot.log", root_build_dir),

"--startup_src",

rebase_path("$target_gen_dir/snapshot.cc", root_build_dir),

]

« no previous file with comments | « no previous file | tools/gyp/v8.gyp » ('j') | tools/ll_prof.py » ('J')