Implement NativeWidgetMac::ReorderNativeViews

ui/views/cocoa/bridged_native_widget.h

 // Copyright 2014 The Chromium Authors. All rights reserved.

[tapted, 2016/03/17 08:18:58]

CL description: perhaps something like `Implement
NativeWidgetMac::ReorderNativeViews`

NativeWidgetMac doesn't currently take into account native view order when
attaching NSViews in NativeViewHost...

etc.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_COCOA_BRIDGED_NATIVE_WIDGET_H_
 #define UI_VIEWS_COCOA_BRIDGED_NATIVE_WIDGET_H_
 
 #import <Cocoa/Cocoa.h>
 
 #include <vector>
 
 #import "base/mac/scoped_nsobject.h"
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 #import "ui/accelerated_widget_mac/accelerated_widget_mac.h"
 #include "ui/base/ime/input_method_delegate.h"
 #include "ui/compositor/layer_owner.h"
 #import "ui/views/cocoa/bridged_native_widget_owner.h"
 #import "ui/views/cocoa/cocoa_mouse_capture_delegate.h"
 #import "ui/views/focus/focus_manager.h"
 #include "ui/views/views_export.h"
 #include "ui/views/widget/widget.h"
+#include "ui/views/widget/widget_mac_utils.h"
 
 @class BridgedContentView;
 @class ViewsNSWindowDelegate;
 
 namespace ui {
 class InputMethod;
 }
 
 namespace views {
 namespace test {
@@ skipping 116 matching lines @@
   // See widget.h for documentation.
   ui::InputMethod* GetInputMethod();
 
   // The restored bounds will be derived from the current NSWindow frame unless
   // fullscreen or transitioning between fullscreen states.
   gfx::Rect GetRestoredBounds() const;
 
   // Creates a ui::Compositor which becomes responsible for drawing the window.
   void CreateLayer(ui::LayerType layer_type, bool translucent);
 
+  // Updates associated_views_ on NativeViewHost::Attach/Detach

[tapted, 2016/03/17 08:18:58]

nit: .. |associated_views_| .. NativeViewHost::Attach()/Detach().

+  void SetAssociationForView(const views::View* view, NSView* native_view);
+  void ClearAssociationForView(const views::View* view);
+  void ReorderChildViews();

[tapted, 2016/03/17 08:18:58]

This should have a separate comment

+
   NativeWidgetMac* native_widget_mac() { return native_widget_mac_; }
   BridgedContentView* ns_view() { return bridged_view_; }
   NSWindow* ns_window() { return window_; }
 
   TooltipManager* tooltip_manager() { return tooltip_manager_.get(); }
 
   // The parent widget specified in Widget::InitParams::parent. If non-null, the
   // parent will close children before the parent closes, and children will be
   // raised above their parent when window z-order changes.
   BridgedNativeWidgetOwner* parent() { return parent_; }
@@ skipping 113 matching lines @@
   bool window_visible_;
 
   // If true, the window is either visible, or wants to be visible but is
   // currently hidden due to having a hidden parent.
   bool wants_to_be_visible_;
 
   // If true, the window has been made visible or changed shape and the window
   // shadow needs to be invalidated when a frame is received for the new shape.
   bool invalidate_shadow_on_frame_swap_ = false;
 
+  // Contains NativeViewHost->gfx::NativeView associations.
+  views::AssociatedViews associated_views_;
+
   DISALLOW_COPY_AND_ASSIGN(BridgedNativeWidget);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_COCOA_BRIDGED_NATIVE_WIDGET_H_