Begin tracking GL_TEXTURE_ and GL_DRAW_INDIRECT_ buffer bindings

Begin tracking GL_TEXTURE_ and GL_DRAW_INDIRECT_ buffer bindings

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1796713005

Committed: https://skia.googlesource.com/skia/+/c161310ffdbbcb3b023da2e375faefd211fa52e8

[Chris Dalton, 2016-03-14 15:43:25]

Description was changed from

==========
Begin tracking GL_TEXTURE_ and GL_DRAW_INDIRECT_ buffer bindings

BUG=skia:
==========

to

==========
Begin tracking GL_TEXTURE_ and GL_DRAW_INDIRECT_ buffer bindings

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Chris Dalton, 2016-03-14 15:46:52]

cdalton@nvidia.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com

[Chris Dalton, 2016-03-14 15:46:53]

https://codereview.chromium.org/1796713005/diff/1/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1796713005/diff/1/src/gpu/gl/GrGLGpu.cpp#newc...
src/gpu/gl/GrGLGpu.cpp:2214: switch (type) {
This has technically been a bit dangerous because if the same buffer object is
bound to more than one target, the tracking state won't be updated properly for
the other targets.

[bsalomon, 2016-03-16 13:42:23]

lgtm

https://codereview.chromium.org/1796713005/diff/1/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1796713005/diff/1/src/gpu/gl/GrGLGpu.cpp#newc...
src/gpu/gl/GrGLGpu.cpp:2214: switch (type) {
On 2016/03/14 15:46:53, Chris Dalton wrote:
> This has technically been a bit dangerous because if the same buffer object is
> bound to more than one target, the tracking state won't be updated properly
for
> the other targets.

Right now the buffer type is inherent to the Gr-object. So it seems safe. But
that brings up the question of whether it should be. We originally separated
index and vertex buffers because we had a D3D9 backend but that was deleted many
years ago.

[Chris Dalton, 2016-03-16 14:39:03]

The CQ bit was checked by cdalton@nvidia.com

[commit-bot: I haz the power, 2016-03-16 14:39:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1796713005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1796713005/1

[commit-bot: I haz the power, 2016-03-16 14:48:22]

Description was changed from

==========
Begin tracking GL_TEXTURE_ and GL_DRAW_INDIRECT_ buffer bindings

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Begin tracking GL_TEXTURE_ and GL_DRAW_INDIRECT_ buffer bindings

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/c161310ffdbbcb3b023da2e375faefd211fa52e8
==========

[commit-bot: I haz the power, 2016-03-16 14:48:23]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c161310ffdbbcb3b023da2e375faefd211fa52e8