Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1796623002: Added ink drop hover/ripple to menu hosting bookmark buttons. (Closed)

Created:
4 years, 9 months ago by bruthig
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Added ink drop hover/ripple to menu hosting bookmark buttons. BUG=592058 TEST=InkDropAnimationControllerImplTest.* TEST=InkDropAnimationTest.* TEST=CustomButtonTest.InkDropAfterShowingContextMenu TEST=CustomButtonTest.InkDropAfterTryingToShowContextMenu TEST=Manual Review URL: https://codereview.chromium.org/1757993004 Cr-Commit-Position: refs/heads/master@{#380786} (cherry picked from commit db5c17d7fd792247f8e852881f16a4d5ab228afb) Committed: https://chromium.googlesource.com/chromium/src/+/0d430a564c7a944882e6435e39861429fc72cd5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+364 lines, -61 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 6 chunks +78 lines, -10 lines 0 comments Download
M ui/views/animation/button_ink_drop_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/animation/button_ink_drop_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/animation/flood_fill_ink_drop_animation.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/views/animation/flood_fill_ink_drop_animation.cc View 4 chunks +17 lines, -4 lines 0 comments Download
M ui/views/animation/ink_drop_animation.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/views/animation/ink_drop_animation.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M ui/views/animation/ink_drop_animation_controller.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/views/animation/ink_drop_animation_controller_factory.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/views/animation/ink_drop_animation_controller_impl.h View 2 chunks +9 lines, -0 lines 0 comments Download
M ui/views/animation/ink_drop_animation_controller_impl.cc View 4 chunks +22 lines, -7 lines 0 comments Download
M ui/views/animation/ink_drop_animation_controller_impl_unittest.cc View 3 chunks +25 lines, -2 lines 0 comments Download
M ui/views/animation/ink_drop_animation_unittest.cc View 1 chunk +46 lines, -0 lines 0 comments Download
M ui/views/animation/ink_drop_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/animation/square_ink_drop_animation.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/views/animation/square_ink_drop_animation.cc View 4 chunks +18 lines, -1 line 0 comments Download
M ui/views/animation/test/test_ink_drop_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/animation/test/test_ink_drop_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/controls/button/custom_button.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/controls/button/custom_button_unittest.cc View 7 chunks +73 lines, -30 lines 0 comments Download
M ui/views/controls/button/menu_button.h View 2 chunks +5 lines, -2 lines 0 comments Download
M ui/views/controls/button/menu_button.cc View 2 chunks +12 lines, -4 lines 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
bruthig
4 years, 9 months ago (2016-03-13 21:04:14 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
0d430a564c7a944882e6435e39861429fc72cd5d.

Powered by Google App Engine
This is Rietveld 408576698