Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1796573005: Do not show deprecation message for ::shadow and /deep/ on querySelector (Closed)

Created:
4 years, 9 months ago by kochi
Modified:
4 years, 9 months ago
Reviewers:
hayato
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not show deprecation message for ::shadow and /deep/ on querySelector For ::shadow pseudo element and /deep/ combinator, which is deprecated for CSS but still is allowed for querySelector[All]. BUG=594458 Committed: https://crrev.com/afe8b19377eba0d66ce30c8753feee2e92fc767b Cr-Commit-Position: refs/heads/master@{#381140}

Patch Set 1 #

Patch Set 2 : fix layout test expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/SelectorAPI/only-shadow-host-in-shadow-tree-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/all-in-shadow-tree-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/querySelector-for-multiple-shadowroots-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/querySelector-for-useragent-shadowroot-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/querySelector-with-detached-node-distribution-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/querySelector-with-distribution-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/querySelector-with-shadow-all-and-shadow-deep-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/closed-mode-deep-combinators-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/SelectorChecker.h View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/SelectorQuery.cpp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1796573005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1796573005/1
4 years, 9 months ago (2016-03-14 07:48:15 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/194811)
4 years, 9 months ago (2016-03-14 08:33:05 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1796573005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1796573005/20001
4 years, 9 months ago (2016-03-14 08:37:10 UTC) #6
kochi
PTAL
4 years, 9 months ago (2016-03-14 09:38:56 UTC) #8
hayato
lgtm
4 years, 9 months ago (2016-03-14 10:50:44 UTC) #9
hayato
Is it difficult to remove deprecation warning only for chrome:// pages?
4 years, 9 months ago (2016-03-14 10:51:16 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-14 11:39:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1796573005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1796573005/20001
4 years, 9 months ago (2016-03-15 00:45:27 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-15 00:50:37 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/afe8b19377eba0d66ce30c8753feee2e92fc767b Cr-Commit-Position: refs/heads/master@{#381140}
4 years, 9 months ago (2016-03-15 00:52:23 UTC) #17
kochi
On 2016/03/14 10:51:16, hayato wrote: > Is it difficult to remove deprecation warning only for ...
4 years, 9 months ago (2016-03-15 00:55:05 UTC) #18
kochi
4 years, 9 months ago (2016-03-15 10:55:25 UTC) #19
Message was sent while issue was closed.
On 2016/03/15 00:55:05, kochi wrote:
> On 2016/03/14 10:51:16, hayato wrote:
> > Is it difficult to remove deprecation warning only for chrome:// pages?
> 
> Let me try today.

On the second thought, special handling of chrome:// in Blink is not a good
thing to do.

Powered by Google App Engine
This is Rietveld 408576698