Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 179643003: Revert "Allow ICs to be generated for own global proxy." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/code-stubs.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1289 matching lines...) Expand 10 before | Expand all | Expand 10 after
1300 } 1300 }
1301 1301
1302 1302
1303 #undef __ 1303 #undef __
1304 #define __ ACCESS_MASM(masm()) 1304 #define __ ACCESS_MASM(masm())
1305 1305
1306 1306
1307 Handle<Code> StoreStubCompiler::CompileStoreInterceptor( 1307 Handle<Code> StoreStubCompiler::CompileStoreInterceptor(
1308 Handle<JSObject> object, 1308 Handle<JSObject> object,
1309 Handle<Name> name) { 1309 Handle<Name> name) {
1310 Label miss;
1311
1312 // Check that the map of the object hasn't changed.
1313 __ CheckMap(receiver(), scratch1(), Handle<Map>(object->map()), &miss,
1314 DO_SMI_CHECK);
1315
1316 // Perform global security token check if needed.
1317 if (object->IsJSGlobalProxy()) {
1318 __ CheckAccessGlobalProxy(receiver(), scratch1(), &miss);
1319 }
1320
1321 // Stub is never generated for non-global objects that require access
1322 // checks.
1323 ASSERT(object->IsJSGlobalProxy() || !object->IsAccessCheckNeeded());
1324
1310 __ Push(receiver(), this->name(), value()); 1325 __ Push(receiver(), this->name(), value());
1311 1326
1312 // Do tail-call to the runtime system. 1327 // Do tail-call to the runtime system.
1313 ExternalReference store_ic_property = 1328 ExternalReference store_ic_property =
1314 ExternalReference(IC_Utility(IC::kStoreInterceptorProperty), isolate()); 1329 ExternalReference(IC_Utility(IC::kStoreInterceptorProperty), isolate());
1315 __ TailCallExternalReference(store_ic_property, 3, 1); 1330 __ TailCallExternalReference(store_ic_property, 3, 1);
1316 1331
1332 // Handle store cache miss.
1333 __ bind(&miss);
1334 TailCallBuiltin(masm(), MissBuiltin(kind()));
1335
1317 // Return the generated code. 1336 // Return the generated code.
1318 return GetCode(kind(), Code::FAST, name); 1337 return GetCode(kind(), Code::FAST, name);
1319 } 1338 }
1320 1339
1321 1340
1322 Handle<Code> LoadStubCompiler::CompileLoadNonexistent(Handle<HeapType> type, 1341 Handle<Code> LoadStubCompiler::CompileLoadNonexistent(Handle<HeapType> type,
1323 Handle<JSObject> last, 1342 Handle<JSObject> last,
1324 Handle<Name> name) { 1343 Handle<Name> name) {
1325 NonexistentHandlerFrontend(type, last, name); 1344 NonexistentHandlerFrontend(type, last, name);
1326 1345
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
1564 // ----------------------------------- 1583 // -----------------------------------
1565 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1584 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1566 } 1585 }
1567 1586
1568 1587
1569 #undef __ 1588 #undef __
1570 1589
1571 } } // namespace v8::internal 1590 } } // namespace v8::internal
1572 1591
1573 #endif // V8_TARGET_ARCH_ARM 1592 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/code-stubs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698