Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: media/base/android/media_codec_util.cc

Issue 1796393002: Remove Exynos from MediaCodec blacklist. Limit MediaTek blacklist. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert hunks. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/android/media_codec_util.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/android/media_codec_util.cc
diff --git a/media/base/android/media_codec_util.cc b/media/base/android/media_codec_util.cc
index 27a2b5ab00c7077b6057269e298e8304f92c48b0..ae726d0b96f1f22997531445db784f2586c7e22c 100644
--- a/media/base/android/media_codec_util.cc
+++ b/media/base/android/media_codec_util.cc
@@ -203,18 +203,16 @@ bool MediaCodecUtil::IsKnownUnaccelerated(const std::string& mime_type,
// HW-acceleration but it doesn't. Android Media guidance is that the
// "OMX.google" prefix is always used for SW decoders, so that's what we
// use. "OMX.SEC.*" codec is Samsung software implementation - report it
- // as unaccelerated as well. Also temporary blacklist Exynos and MediaTek
- // devices while HW decoder video freezes and distortions are
- // investigated - http://crbug.com/446974.
+ // as unaccelerated as well. MediaTek hardware vp8 is known slower than
+ // the software implementation. http://crbug.com/446974.
if (codec_name.length() > 0) {
- return (base::StartsWith(codec_name, "OMX.google.",
- base::CompareCase::SENSITIVE) ||
- base::StartsWith(codec_name, "OMX.SEC.",
- base::CompareCase::SENSITIVE) ||
- base::StartsWith(codec_name, "OMX.MTK.",
- base::CompareCase::SENSITIVE) ||
- base::StartsWith(codec_name, "OMX.Exynos.",
- base::CompareCase::SENSITIVE));
+ return base::StartsWith(codec_name, "OMX.google.",
+ base::CompareCase::SENSITIVE) ||
+ base::StartsWith(codec_name, "OMX.SEC.",
+ base::CompareCase::SENSITIVE) ||
+ (base::StartsWith(codec_name, "OMX.MTK.",
+ base::CompareCase::SENSITIVE) &&
+ mime_type == "video/x-vnd.on2.vp8");
}
return true;
}
@@ -255,4 +253,11 @@ bool MediaCodecUtil::IsVp8DecoderAvailable() {
return Java_MediaCodecUtil_isDecoderSupportedForDevice(env, j_mime.obj());
}
+// static
+bool MediaCodecUtil::IsVp8EncoderAvailable() {
+ // Currently the vp8 encoder and decoder blacklists cover the same devices,
+ // but we have a second method for clarity in future issues.
+ return IsVp8DecoderAvailable();
+}
+
} // namespace media
« no previous file with comments | « media/base/android/media_codec_util.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698