Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1796353002: Provide better script names in CPU profiler. (Closed)

Created:
4 years, 9 months ago by alph
Modified:
4 years, 9 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Provide better script names in CPU profiler. Use script_url when the script name is not available. BUG=chromium:463108 LOG=N Committed: https://crrev.com/3521ffa5a5c0aa29b5a2bb200317bdad84ba17e8 Cr-Commit-Position: refs/heads/master@{#34793}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M src/profiler/cpu-profiler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/profiler/cpu-profiler.cc View 3 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1796353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1796353002/1
4 years, 9 months ago (2016-03-14 23:39:15 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-15 00:01:27 UTC) #4
alph
4 years, 9 months ago (2016-03-15 11:50:08 UTC) #6
alph
Ben, could you please take a look. Thanks.
4 years, 9 months ago (2016-03-15 15:54:39 UTC) #8
titzer
On 2016/03/15 15:54:39, alph wrote: > Ben, could you please take a look. Thanks. lgtm
4 years, 9 months ago (2016-03-15 17:00:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1796353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1796353002/1
4 years, 9 months ago (2016-03-15 17:07:28 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-15 17:09:29 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 17:10:32 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3521ffa5a5c0aa29b5a2bb200317bdad84ba17e8
Cr-Commit-Position: refs/heads/master@{#34793}

Powered by Google App Engine
This is Rietveld 408576698