Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1796303002: Tidy fpdftext/ directory (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Tidy fpdftext/ directory Make .h/.cpp filenames match. Add header for unicodenormalization.cpp Remove dead code. R=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/6d6f1f4078c745e6ba7560a71c5ff65d1aa7d963

Patch Set 1 #

Patch Set 2 : Trailing comment. #

Patch Set 3 : Missing include. #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -288 lines) Patch
M BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A + core/fpdftext/fpdf_text_int.h View 1 2 3 2 chunks +3 lines, -5 lines 0 comments Download
M core/fpdftext/fpdf_text_int.cpp View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M core/fpdftext/fpdf_text_int_unittest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
D core/fpdftext/text_int.h View 1 2 3 1 chunk +0 lines, -246 lines 0 comments Download
A + core/fpdftext/unicodenormalization.h View 1 chunk +4 lines, -9 lines 0 comments Download
M core/fpdftext/unicodenormalization.cpp View 1 2 2 chunks +6 lines, -24 lines 0 comments Download
M pdfium.gyp View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Tom Sepez
Dan, for review.
4 years, 9 months ago (2016-03-14 20:18:03 UTC) #3
dsinclair
lgtm
4 years, 9 months ago (2016-03-14 20:20:43 UTC) #4
Tom Sepez
4 years, 9 months ago (2016-03-15 16:10:10 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
6d6f1f4078c745e6ba7560a71c5ff65d1aa7d963 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698