Add an option to disable net::BidirectionalStreamQuicImpl

net/http/http_network_session.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_NETWORK_SESSION_H_
 #define NET_HTTP_HTTP_NETWORK_SESSION_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 167 matching lines @@
     // If true, disable preconnections if QUIC can do 0RTT.
     bool quic_disable_preconnect_if_0rtt;
     // List of hosts for which QUIC is explicitly whitelisted.
     std::unordered_set<std::string> quic_host_whitelist;
     // If true, active QUIC sessions may be migrated onto a new network when
     // the platform indicates that the default network is changing.
     bool quic_migrate_sessions_on_network_change;
     // If true, active QUIC sessions experiencing poor connectivity may be
     // migrated onto a new network.
     bool quic_migrate_sessions_early;
+    // If false, net::BidirectionalStreamQuicImpl will not be used when

[mef, 2016/03/15 19:51:10]

I think it should say 'If true'...

[xunjieli, 2016/03/15 20:15:20]

Done.

[Ryan Hamilton, 2016/03/15 22:41:44]

I think a better comment might be:

// If true, then bidirectional stream over QUIC will be disabled. 

[xunjieli, 2016/03/16 15:47:04]

Done.

+    // requesting a net::BidirectionalStream.
+    bool disable_bidirectional_stream_quic_impl;

[mef, 2016/03/15 19:51:10]

should we call it 'quic_disable_bidirectional_stream'?

[xunjieli, 2016/03/15 20:15:20]

I am not sure. It isn't a feature of QUIC (but a flag on the bidi wrapper on top
of QUIC). I am not sure if it should be lumped together with other quic feature
flags above.

[Ryan Hamilton, 2016/03/15 22:41:44]

I like mef's name.

[xunjieli, 2016/03/16 15:47:04]

Done. Great!

+
     ProxyDelegate* proxy_delegate;
     // Enable support for Token Binding.
     bool enable_token_binding;
   };
 
   enum SocketPoolType {
     NORMAL_SOCKET_POOL,
     WEBSOCKET_SOCKET_POOL,
     NUM_SOCKET_POOL_TYPES
   };
@@ skipping 97 matching lines @@
 
   NextProtoVector next_protos_;
   bool enabled_protocols_[NUM_VALID_ALTERNATE_PROTOCOLS];
 
   Params params_;
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_NETWORK_SESSION_H_