Issue 179613002: Revert r19455 "Load target types and handlers before IC computation."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 179613002: Revert r19455 "Load target types and handlers before IC computation." (Closed)

Created:
6 years, 10 months ago by ulan

Modified:
6 years, 10 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert r19455 "Load target types and handlers before IC computation." It caused performance regression in dromaeo/jslib. BUG=346149 LOG=N R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19537

Patch Set 1 #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -57 lines)			Patch
	M	src/ic.h	View		3 chunks	+1 line, -17 lines	0 comments	Download
	M	src/ic.cc	View		11 chunks	+55 lines, -40 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ulan

https://codereview.chromium.org/179613002/diff/1/src/ic.cc File src/ic.cc (right): https://codereview.chromium.org/179613002/diff/1/src/ic.cc#newcode1422 src/ic.cc:1422: if (target_receiver_maps.length() == 0) { Looks like the regression ...

6 years, 10 months ago (2014-02-25 10:18:30 UTC) #3

ulan

6 years, 10 months ago (2014-02-25 10:52:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r19537 (tree was closed).

Expand Messages | Collapse Messages