Implement WiFi Display media packetizer.

[chrome.displaySource] Implement media packetizer.

The WiFi Display media packetizer extends a WiFi Display transport stream
packetizer and packetizes Transport Stream (TS) packets further to media
datagram (RTP) packets which can be passed to a remote sink over an UDP
connection.

This is part of a WiFi Display packetizer patch series:
 * https://codereview.chromium.org/1796123002/
   WiFi Display elementary stream packetizer
 * https://codereview.chromium.org/1800493003/
   WiFi Display elementary stream descriptors
 * https://codereview.chromium.org/1797953002/
   WiFi Display transport stream packetizer
 * https://codereview.chromium.org/1796073003/  <-- this CL
   WiFi Display media packetizer

BUG=242107
Committed: https://crrev.com/208650d9e239e6d8119ba9fb75234c168df177d6
Cr-Commit-Position: refs/heads/master@{#382829}

[e_hakkinen, 2016-03-14 10:26:01]

Description was changed from

==========
Implement WiFi Display media packetizer.
==========

to

==========
Implement WiFi Display media packetizer.

This is part of a WiFi Display packetizer patch series:
 * https://codereview.chromium.org/1796123002/
   WiFi Display elementary stream packetizer
 * https://codereview.chromium.org/1800493003/
   WiFi Display elementary stream descriptors
 * https://codereview.chromium.org/1797953002/
   WiFi Display transport stream packetizer
 * https://codereview.chromium.org/1796073003/
   WiFi Display media packetizer
==========

[e_hakkinen, 2016-03-14 10:26:01]

eero.hakkinen@intel.com changed reviewers:
+ alexander.shalamov@intel.com, mikhail.pozdnyakov@intel.com

[e_hakkinen, 2016-03-14 11:18:50]

Description was changed from

==========
Implement WiFi Display media packetizer.

This is part of a WiFi Display packetizer patch series:
 * https://codereview.chromium.org/1796123002/
   WiFi Display elementary stream packetizer
 * https://codereview.chromium.org/1800493003/
   WiFi Display elementary stream descriptors
 * https://codereview.chromium.org/1797953002/
   WiFi Display transport stream packetizer
 * https://codereview.chromium.org/1796073003/
   WiFi Display media packetizer
==========

to

==========
[chrome.displaySource] Implement media packetizer.

The WiFi Display media packetizer extends a WiFi Display transport stream
packetizer and packetizes Transport Stream (TS) packets further to media
datagram (RTP) packets which can be passed to a remote sink over an UDP
connection.

This is part of a WiFi Display packetizer patch series:
 * https://codereview.chromium.org/1796123002/
   WiFi Display elementary stream packetizer
 * https://codereview.chromium.org/1800493003/
   WiFi Display elementary stream descriptors
 * https://codereview.chromium.org/1797953002/
   WiFi Display transport stream packetizer
 * https://codereview.chromium.org/1796073003/  <-- this CL
   WiFi Display media packetizer

BUG=242107
==========

[e_hakkinen, 2016-03-14 14:27:34]

Patchset #1 (id:1) has been deleted

[e_hakkinen, 2016-03-14 14:47:06]

eero.hakkinen@intel.com changed reviewers:
+ asargent@chromium.org

[e_hakkinen, 2016-03-15 10:16:02]

Patchset #1 (id:20001) has been deleted

[e_hakkinen, 2016-03-22 11:07:16]

Patchset #1 (id:40001) has been deleted

[asargent_no_longer_on_chrome, 2016-03-22 19:15:37]

lgtm with a couple of comments

https://codereview.chromium.org/1796073003/diff/60001/extensions/renderer/api...
File
extensions/renderer/api/display_source/wifi_display/wifi_display_media_packetizer.cc
(right):

https://codereview.chromium.org/1796073003/diff/60001/extensions/renderer/api...
extensions/renderer/api/display_source/wifi_display/wifi_display_media_packetizer.cc:33:
crypto::RandBytes(&sequence_number_, sizeof(sequence_number_));
My immediate reaction reading this line is to be a little worried about whether
uint16_t has a wide enough range to effectively prevent collisions. Are there
going to a be a lot of these objects alive at the same time (in the "objects in
memory" or "packets on the local network" sense)? Are there bad consequences if
you did get a collision? Is it only the combination of
synchronization_source_identifier_ and sequence_number_ that need to be unique?

If you've already thought about all this and concluded it's ok, consider adding
a comment explaining why.

https://codereview.chromium.org/1796073003/diff/60001/extensions/renderer/api...
File
extensions/renderer/api/display_source/wifi_display/wifi_display_media_packetizer.h
(right):

https://codereview.chromium.org/1796073003/diff/60001/extensions/renderer/api...
extensions/renderer/api/display_source/wifi_display/wifi_display_media_packetizer.h:24:
DISALLOW_COPY_AND_ASSIGN_WITH_MOVE_FOR_BIND(WiFiDisplayMediaDatagramPacket);
Do you need this to be a subclass, or could you just have a "using" alias?

(ie is the behavior that DISALLOW_COPY_AND_ASSIGN_WITH_MOVE_FOR_BIND gets you
actually important?)

[e_hakkinen, 2016-03-23 10:22:46]

https://codereview.chromium.org/1796073003/diff/60001/extensions/renderer/api...
File
extensions/renderer/api/display_source/wifi_display/wifi_display_media_packetizer.h
(right):

https://codereview.chromium.org/1796073003/diff/60001/extensions/renderer/api...
extensions/renderer/api/display_source/wifi_display/wifi_display_media_packetizer.h:24:
DISALLOW_COPY_AND_ASSIGN_WITH_MOVE_FOR_BIND(WiFiDisplayMediaDatagramPacket);
On 2016/03/22 19:15:36, Antony Sargent wrote:
> Do you need this to be a subclass, or could you just have a "using" alias?
> 
> (ie is the behavior that DISALLOW_COPY_AND_ASSIGN_WITH_MOVE_FOR_BIND gets you
> actually important?)

Move semantics is quite important in order to avoid extra copies of payload
data. So yes, it is.

[e_hakkinen, 2016-03-23 10:23:37]

The CQ bit was checked by eero.hakkinen@intel.com

[e_hakkinen, 2016-03-23 10:23:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/1796073003/#ps80001
(title: "Rebase, comments")

[commit-bot: I haz the power, 2016-03-23 10:23:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1796073003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1796073003/80001

[commit-bot: I haz the power, 2016-03-23 11:19:10]

Description was changed from

==========
[chrome.displaySource] Implement media packetizer.

The WiFi Display media packetizer extends a WiFi Display transport stream
packetizer and packetizes Transport Stream (TS) packets further to media
datagram (RTP) packets which can be passed to a remote sink over an UDP
connection.

This is part of a WiFi Display packetizer patch series:
 * https://codereview.chromium.org/1796123002/
   WiFi Display elementary stream packetizer
 * https://codereview.chromium.org/1800493003/
   WiFi Display elementary stream descriptors
 * https://codereview.chromium.org/1797953002/
   WiFi Display transport stream packetizer
 * https://codereview.chromium.org/1796073003/  <-- this CL
   WiFi Display media packetizer

BUG=242107
==========

to

==========
[chrome.displaySource] Implement media packetizer.

The WiFi Display media packetizer extends a WiFi Display transport stream
packetizer and packetizes Transport Stream (TS) packets further to media
datagram (RTP) packets which can be passed to a remote sink over an UDP
connection.

This is part of a WiFi Display packetizer patch series:
 * https://codereview.chromium.org/1796123002/
   WiFi Display elementary stream packetizer
 * https://codereview.chromium.org/1800493003/
   WiFi Display elementary stream descriptors
 * https://codereview.chromium.org/1797953002/
   WiFi Display transport stream packetizer
 * https://codereview.chromium.org/1796073003/  <-- this CL
   WiFi Display media packetizer

BUG=242107
==========

[commit-bot: I haz the power, 2016-03-23 11:19:11]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-03-23 11:20:19]

Description was changed from

==========
[chrome.displaySource] Implement media packetizer.

The WiFi Display media packetizer extends a WiFi Display transport stream
packetizer and packetizes Transport Stream (TS) packets further to media
datagram (RTP) packets which can be passed to a remote sink over an UDP
connection.

This is part of a WiFi Display packetizer patch series:
 * https://codereview.chromium.org/1796123002/
   WiFi Display elementary stream packetizer
 * https://codereview.chromium.org/1800493003/
   WiFi Display elementary stream descriptors
 * https://codereview.chromium.org/1797953002/
   WiFi Display transport stream packetizer
 * https://codereview.chromium.org/1796073003/  <-- this CL
   WiFi Display media packetizer

BUG=242107
==========

to

==========
[chrome.displaySource] Implement media packetizer.

The WiFi Display media packetizer extends a WiFi Display transport stream
packetizer and packetizes Transport Stream (TS) packets further to media
datagram (RTP) packets which can be passed to a remote sink over an UDP
connection.

This is part of a WiFi Display packetizer patch series:
 * https://codereview.chromium.org/1796123002/
   WiFi Display elementary stream packetizer
 * https://codereview.chromium.org/1800493003/
   WiFi Display elementary stream descriptors
 * https://codereview.chromium.org/1797953002/
   WiFi Display transport stream packetizer
 * https://codereview.chromium.org/1796073003/  <-- this CL
   WiFi Display media packetizer

BUG=242107

Committed: https://crrev.com/208650d9e239e6d8119ba9fb75234c168df177d6
Cr-Commit-Position: refs/heads/master@{#382829}
==========

[commit-bot: I haz the power, 2016-03-23 11:20:20]

Patchset 2 (id:??) landed as
https://crrev.com/208650d9e239e6d8119ba9fb75234c168df177d6
Cr-Commit-Position: refs/heads/master@{#382829}