Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1796033002:
Add GYP support for Chrome's mojo manifest (Closed)
|
Created:
4 years, 9 months ago by Ken Rockot(use gerrit already) Modified:
4 years, 9 months ago Reviewers:
Ben Goodger (Google) CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd GYP support for Chrome's mojo manifest
BUG=None
Committed: https://crrev.com/28b466c329fc4dd7f6a41ce94f993ce17f068e8d
Cr-Commit-Position: refs/heads/master@{#381193}
Patch Set 1 #Patch Set 2 : #
Messages
Total messages: 21 (11 generated)
rockot@chromium.org changed reviewers: + ben@chromium.org
Perhaps a necessary evil if we want to keep moving. Also, I think we should start shipping these manifests with our builds?
Description was changed from ========== Add GYP support Chrome's mojo manifest BUG=None ========== to ========== Add GYP support for Chrome's mojo manifest BUG=None ==========
lgtm
The CQ bit was checked by rockot@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1796033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1796033002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by rockot@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1796033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1796033002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by rockot@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1796033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1796033002/1
The CQ bit was unchecked by rockot@chromium.org
The CQ bit was checked by rockot@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org Link to the patchset: https://codereview.chromium.org/1796033002/#ps20001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1796033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1796033002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add GYP support for Chrome's mojo manifest BUG=None ========== to ========== Add GYP support for Chrome's mojo manifest BUG=None Committed: https://crrev.com/28b466c329fc4dd7f6a41ce94f993ce17f068e8d Cr-Commit-Position: refs/heads/master@{#381193} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/28b466c329fc4dd7f6a41ce94f993ce17f068e8d Cr-Commit-Position: refs/heads/master@{#381193} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
