Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1795993002:
Dropping shadowed variable. (Closed)
|
Created:
4 years, 9 months ago by bradnelson Modified:
4 years, 9 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionDropping shadowed variable.
Accidentally introduced in:
https://crrev.com/da632baac7e28d370d9893676c8d1d3e901a4400
crrev.com/1652963004
BUG= https://code.google.com/p/v8/issues/detail?id=4203
BUG=427616
TEST=test-asm-validator
R=brucedawson@chromium.org,aseemgarg@chromium.org
LOG=N
Committed: https://crrev.com/5fceb67049232c92897da6690c35821515a0f0d0
Cr-Commit-Position: refs/heads/master@{#34737}
Patch Set 1 #Patch Set 2 : delete the right one :-) #Messages
Total messages: 16 (7 generated)
bradnelson@google.com changed reviewers: + bradnelson@google.com
Maybe add BUG=427616 (/analyze bug) and maybe link to crrev.com/1652963004 in the description instead of the hash? But the change lgtm
Description was changed from ========== Dropping shadowed variable. Accidentally introduced in: https://crrev.com/da632baac7e28d370d9893676c8d1d3e901a4400 BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-asm-validator R=brucedawson@chromium.org,aseemgarg@chromium.org LOG=N ========== to ========== Dropping shadowed variable. Accidentally introduced in: https://crrev.com/da632baac7e28d370d9893676c8d1d3e901a4400 BUG= https://code.google.com/p/v8/issues/detail?id=4203 BUG=427616 TEST=test-asm-validator R=brucedawson@chromium.org,aseemgarg@chromium.org LOG=N ==========
Description was changed from ========== Dropping shadowed variable. Accidentally introduced in: https://crrev.com/da632baac7e28d370d9893676c8d1d3e901a4400 BUG= https://code.google.com/p/v8/issues/detail?id=4203 BUG=427616 TEST=test-asm-validator R=brucedawson@chromium.org,aseemgarg@chromium.org LOG=N ========== to ========== Dropping shadowed variable. Accidentally introduced in: https://crrev.com/da632baac7e28d370d9893676c8d1d3e901a4400 crrev.com/1652963004 BUG= https://code.google.com/p/v8/issues/detail?id=4203 BUG=427616 TEST=test-asm-validator R=brucedawson@chromium.org,aseemgarg@chromium.org LOG=N ==========
On 2016/03/14 06:06:29, brucedawson wrote: > Maybe add BUG=427616 (/analyze bug) and maybe link to crrev.com/1652963004 in > the description instead of the hash? > > But the change lgtm What I meant was the change looks good except that the wrong line was deleted :-) You need to delete line 959 instead of 956.
Yep. :-)
The CQ bit was checked by bradnelson@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from brucedawson@chromium.org Link to the patchset: https://codereview.chromium.org/1795993002/#ps20001 (title: "delete the right one :-)")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1795993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1795993002/20001
Message was sent while issue was closed.
Description was changed from ========== Dropping shadowed variable. Accidentally introduced in: https://crrev.com/da632baac7e28d370d9893676c8d1d3e901a4400 crrev.com/1652963004 BUG= https://code.google.com/p/v8/issues/detail?id=4203 BUG=427616 TEST=test-asm-validator R=brucedawson@chromium.org,aseemgarg@chromium.org LOG=N ========== to ========== Dropping shadowed variable. Accidentally introduced in: https://crrev.com/da632baac7e28d370d9893676c8d1d3e901a4400 crrev.com/1652963004 BUG= https://code.google.com/p/v8/issues/detail?id=4203 BUG=427616 TEST=test-asm-validator R=brucedawson@chromium.org,aseemgarg@chromium.org LOG=N ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Dropping shadowed variable. Accidentally introduced in: https://crrev.com/da632baac7e28d370d9893676c8d1d3e901a4400 crrev.com/1652963004 BUG= https://code.google.com/p/v8/issues/detail?id=4203 BUG=427616 TEST=test-asm-validator R=brucedawson@chromium.org,aseemgarg@chromium.org LOG=N ========== to ========== Dropping shadowed variable. Accidentally introduced in: https://crrev.com/da632baac7e28d370d9893676c8d1d3e901a4400 crrev.com/1652963004 BUG= https://code.google.com/p/v8/issues/detail?id=4203 BUG=427616 TEST=test-asm-validator R=brucedawson@chromium.org,aseemgarg@chromium.org LOG=N Committed: https://crrev.com/5fceb67049232c92897da6690c35821515a0f0d0 Cr-Commit-Position: refs/heads/master@{#34737} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/5fceb67049232c92897da6690c35821515a0f0d0 Cr-Commit-Position: refs/heads/master@{#34737}
Message was sent while issue was closed.
DBC: the right format for bugdroid to understand the BUG line is "project:issuenumber", so in this case: BUG=v8:4203,chromium:427616
Message was sent while issue was closed.
Ah, ok. Thanks Jakob. |
