Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1795873002: FLAG_print_code_stubs should respect FLAG_redirect_code_traces (Closed)

Created:
4 years, 9 months ago by ofrobots
Modified:
4 years, 9 months ago
Reviewers:
Yang, Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

FLAG_print_code_stubs should respect FLAG_redirect_code_traces Stub code traces should also be redirected to the file specified by the user. R=yangguo@chromium.org BUG= Committed: https://crrev.com/9cda962bfcd663720d767b17b6d7e068d4eee904 Cr-Commit-Position: refs/heads/master@{#34792}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/ic/access-compiler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (9 generated)
ofrobots
4 years, 9 months ago (2016-03-13 22:12:06 UTC) #1
Yang
On 2016/03/13 22:12:06, ofrobots wrote: lgtm.
4 years, 9 months ago (2016-03-14 06:25:09 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1795873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1795873002/1
4 years, 9 months ago (2016-03-14 06:25:15 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-14 06:45:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1795873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1795873002/1
4 years, 9 months ago (2016-03-14 06:46:08 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/12294)
4 years, 9 months ago (2016-03-14 06:49:19 UTC) #10
Jakob Kummerow
lgtm
4 years, 9 months ago (2016-03-15 10:27:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1795873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1795873002/1
4 years, 9 months ago (2016-03-15 16:19:21 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-15 16:50:53 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 16:52:28 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9cda962bfcd663720d767b17b6d7e068d4eee904
Cr-Commit-Position: refs/heads/master@{#34792}

Powered by Google App Engine
This is Rietveld 408576698