Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: content/browser/service_worker/service_worker_metrics.h

Issue 1795863006: service worker: Attribute purpose to start worker attempts for UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: patch for landing? Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_metrics.h
diff --git a/content/browser/service_worker/service_worker_metrics.h b/content/browser/service_worker/service_worker_metrics.h
index 6e4e3a4fb12047d5f82ead457ef75cb7ac3714a6..6ad0663ac389328ebe4789a4f9b883b3a0c42910 100644
--- a/content/browser/service_worker/service_worker_metrics.h
+++ b/content/browser/service_worker/service_worker_metrics.h
@@ -76,7 +76,7 @@ class ServiceWorkerMetrics {
enum class EventType {
ACTIVATE,
INSTALL,
- FETCH,
+ FETCH, // Deprecated, use a more specific FETCH_ type.
SYNC,
NOTIFICATION_CLICK,
PUSH,
@@ -84,8 +84,12 @@ class ServiceWorkerMetrics {
SERVICE_PORT_CONNECT,
MESSAGE,
NOTIFICATION_CLOSE,
+ FETCH_MAIN_FRAME,
+ FETCH_SUB_FRAME,
+ FETCH_SHARED_WORKER,
+ FETCH_SUB_RESOURCE,
+ UNKNOWN, // Used when event type is not known.
// Add new events to record here.
-
NUM_TYPES
};
@@ -122,6 +126,7 @@ class ServiceWorkerMetrics {
// Records the result of trying to start a worker. |is_installed| indicates
// whether the version has been installed.
static void RecordStartWorkerStatus(ServiceWorkerStatusCode status,
+ EventType purpose,
bool is_installed);
// Records the time taken to successfully start a worker. |is_installed|

Powered by Google App Engine
This is Rietveld 408576698