content/browser/service_worker/service_worker_handle_unittest.cc - Issue 1795863006: service worker: Attribute purpose to start worker attempts for UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_handle_unittest.cc

Issue 1795863006: service worker: Attribute purpose to start worker attempts for UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: patch for landing? Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_fetch_dispatcher.cc ('K') | « content/browser/service_worker/service_worker_fetch_dispatcher.cc ('k') | content/browser/service_worker/service_worker_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_handle_unittest.cc

diff --git a/content/browser/service_worker/service_worker_handle_unittest.cc b/content/browser/service_worker/service_worker_handle_unittest.cc

index 18f89fdc3107beab28b0dfdf9f5bb31044ddd5ce..ae15a98e5499e5c9302d4f140168761858cc523e 100644

--- a/content/browser/service_worker/service_worker_handle_unittest.cc

+++ b/content/browser/service_worker/service_worker_handle_unittest.cc

@@ -2,6 +2,8 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+#include <vector>

#include "base/macros.h"

#include "base/run_loop.h"

#include "content/browser/service_worker/embedded_worker_registry.h"

@@ -142,7 +144,8 @@ TEST_F(ServiceWorkerHandleTest, OnVersionStateChanged) {

// Start the worker, and then...

ServiceWorkerStatusCode status = SERVICE_WORKER_ERROR_FAILED;

- version_->StartWorker(CreateReceiverOnCurrentThread(&status));

+ version_->StartWorker(ServiceWorkerMetrics::EventType::UNKNOWN,

+ CreateReceiverOnCurrentThread(&status));

base::RunLoop().RunUntilIdle();

EXPECT_EQ(SERVICE_WORKER_OK, status);