content/browser/service_worker/service_worker_dispatcher_host_unittest.cc - Issue 1795863006: service worker: Attribute purpose to start worker attempts for UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

Issue 1795863006: service worker: Attribute purpose to start worker attempts for UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: patch for landing? Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_dispatcher_host.cc ('k') | content/browser/service_worker/service_worker_fetch_dispatcher.h » ('j') | content/browser/service_worker/service_worker_fetch_dispatcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

diff --git a/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc b/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

index 84e1b6e0a35c49efd0b425b388fa04730bcfd8b6..9bce9aec5328300bd91f5d067ca8a609fd861709 100644

--- a/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

+++ b/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

@@ -565,7 +565,8 @@ TEST_F(ServiceWorkerDispatcherHostTest, CleanupOnRendererCrash) {

// Start up the worker.

status = SERVICE_WORKER_ERROR_ABORT;

- version->StartWorker(base::Bind(&SaveStatusCallback, &called, &status));

+ version->StartWorker(ServiceWorkerMetrics::EventType::UNKNOWN,

+ base::Bind(&SaveStatusCallback, &called, &status));

base::RunLoop().RunUntilIdle();

EXPECT_TRUE(called);