content/browser/notifications/notification_event_dispatcher_impl.cc - Issue 1795863006: service worker: Attribute purpose to start worker attempts for UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/notifications/notification_event_dispatcher_impl.cc

Issue 1795863006: service worker: Attribute purpose to start worker attempts for UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: patch for landing? Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/navigator_connect/navigator_connect_context_impl.cc ('k') | content/browser/push_messaging/push_messaging_router.cc » ('j') | content/browser/service_worker/service_worker_fetch_dispatcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/notifications/notification_event_dispatcher_impl.cc

diff --git a/content/browser/notifications/notification_event_dispatcher_impl.cc b/content/browser/notifications/notification_event_dispatcher_impl.cc

index ca125fa584f72a2b69200f8bb06381d684351903..e19a1f81aaaebf6826147a8f065a6576658853e3 100644

--- a/content/browser/notifications/notification_event_dispatcher_impl.cc

+++ b/content/browser/notifications/notification_event_dispatcher_impl.cc

@@ -228,6 +228,7 @@ void DoDispatchNotificationClickEvent(

ServiceWorkerVersion::StatusCallback status_callback = base::Bind(

&ServiceWorkerNotificationEventFinished, dispatch_complete_callback);

service_worker_registration->active_version()->RunAfterStartWorker(

+ ServiceWorkerMetrics::EventType::NOTIFICATION_CLICK,

base::Bind(

&DispatchNotificationClickEventOnWorker,

make_scoped_refptr(service_worker_registration->active_version()),

@@ -299,6 +300,7 @@ void DoDispatchNotificationCloseEvent(

dispatch_complete_callback);

if (by_user) {

service_worker_registration->active_version()->RunAfterStartWorker(

+ ServiceWorkerMetrics::EventType::NOTIFICATION_CLOSE,

base::Bind(

&DispatchNotificationCloseEventOnWorker,

make_scoped_refptr(service_worker_registration->active_version()),